From: Johannes Sixt <j6t@kdbg.org>
To: "LI, BO XUAN" <liboxuan@connect.hku.hk>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
philipoakley@iee.org
Subject: Re: [PATCH v3] userdiff.c & doc/gitattributes.txt: add Octave
Date: Fri, 17 May 2019 21:47:44 +0200 [thread overview]
Message-ID: <cb16942d-3e2e-d5b0-4eb8-25937cd9d573@kdbg.org> (raw)
In-Reply-To: <CALM0=-=2PBLm6+pQxUq5L2=8hEUh3nFFheFN=HhN5CUGj6Kfeg@mail.gmail.com>
Am 17.05.19 um 14:19 schrieb LI, BO XUAN:
> On Fri, May 17, 2019 at 7:34 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Johannes Sixt <j6t@kdbg.org> writes:
>>
>>> I'd prefer to keep this list at the minimum necessary as long as it is
>>> hard-coded in C.
>>
>> Yeah, I know that feeling.
>
> So do we reach a consensus? Should I merge the Octave rules into Matlab rules?
Yes, please, that would be very much appreciated. Bonus points if you
add some test cases for the hunk header patterns to the t/t4018 directory.
-- Hannes
next prev parent reply other threads:[~2019-05-17 19:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 0:47 [PATCH] doc/gitattributes: add Octave Boxuan Li
2019-05-10 23:09 ` Philip Oakley
2019-05-10 23:26 ` Ævar Arnfjörð Bjarmason
2019-05-11 2:36 ` LI, BO XUAN
2019-05-11 4:08 ` [PATCH v2] userdiff.c & doc/gitattributes.txt: " Boxuan Li
2019-05-11 4:13 ` [PATCH v3] " Boxuan Li
2019-05-15 5:35 ` Junio C Hamano
2019-05-15 5:57 ` Johannes Sixt
2019-05-15 6:15 ` LI, BO XUAN
2019-05-15 17:46 ` Johannes Sixt
2019-05-16 9:19 ` Junio C Hamano
2019-05-16 19:20 ` Johannes Sixt
2019-05-16 23:33 ` Junio C Hamano
2019-05-17 12:19 ` LI, BO XUAN
2019-05-17 19:47 ` Johannes Sixt [this message]
2019-05-15 5:55 ` [PATCH v4] " Boxuan Li
2019-05-18 3:46 ` [PATCH v5] userdiff: " Boxuan Li
2019-05-20 19:26 ` Johannes Sixt
2019-05-21 14:57 ` [PATCH v6] " Boxuan Li
2019-05-28 16:37 ` [PATCH v5] " Junio C Hamano
2019-05-28 20:26 ` Johannes Sixt
2019-05-29 16:15 ` [PATCH] userdiff: fix grammar and style issues Boxuan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb16942d-3e2e-d5b0-4eb8-25937cd9d573@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liboxuan@connect.hku.hk \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).