git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	patchwork@lists.ozlabs.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Eric Blake <eblake@redhat.com>,
	Christian Schoenebeck <qemu_oss@crudebyte.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes
Date: Fri, 11 Oct 2019 15:36:02 +1100	[thread overview]
Message-ID: <c942d9ce-d8fe-32ca-bedd-1cdb3837823d@linux.ibm.com> (raw)
In-Reply-To: <xmqqblunj461.fsf@gitster-ct.c.googlers.com>

On 11/10/19 3:29 pm, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
> 
>> This might provide an alternate solution (or vice versa). I kind of like
>> this one better in that it doesn't require the sender to do anything
>> differently (but it may be less robust, as it assumes the receiver
>> reliably de-mangling).
> 
> I share the assessment.  I also feel that relying on Reply-To: would
> make the result a lot less reliable (I do not have much problem with
> the use of X-Original-Sender, though).
> 

It would be nice if Mailman could adopt X-Original-Sender too. As it is, 
it adds the original sender to Reply-To, but in some cases (where the 
list is set as reply-to-list, or has a custom reply-to setting) it adds 
to Cc instead. (In the patch that started this thread, I match the name 
from the munged From field against the name in Reply-To/Cc for the case 
where there's multiple Reply-Tos/Ccs.)

For the Patchwork use case, I'm quite okay with accepting the risk of 
using Reply-To, as the alternative is worse, the corner cases are rare, 
and ultimately a maintainer can still fix the odd stuff-up before 
applying the patch.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited


  reply	other threads:[~2019-10-11  4:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191010062047.21549-1-ajd@linux.ibm.com>
2019-10-10 19:41 ` [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes Jonathan Nieder
2019-10-10 21:13   ` Andrew Donnellan
2019-10-10 23:16     ` Daniel Axtens
2019-10-10 23:40       ` Stephen Rothwell
2019-10-10 22:54   ` Jeff King
2019-10-10 23:01     ` Andrew Donnellan
2019-10-10 23:06       ` Jeff King
2019-10-11 15:42       ` Daniel Axtens
2019-10-11 15:51         ` Jeff King
2019-10-13 11:05           ` Andrew Donnellan
2019-10-11  4:29     ` Junio C Hamano
2019-10-11  4:36       ` Andrew Donnellan [this message]
2019-10-11  4:50         ` Andrew Donnellan
2019-10-11 13:13           ` Christian Schoenebeck
2019-10-11 17:36             ` Ian Kelling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c942d9ce-d8fe-32ca-bedd-1cdb3837823d@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=eblake@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=patchwork@lists.ozlabs.org \
    --cc=peff@peff.net \
    --cc=qemu_oss@crudebyte.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).