From: Linus Torvalds <torvalds@linux-foundation.org>
To: Marco Costalba <mcostalba@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [RFC PATCH] Make gitk use --early-output
Date: Sun, 4 Nov 2007 09:53:28 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.0.999.0711040947110.15101@woody.linux-foundation.org> (raw)
In-Reply-To: <e5bfff550711040237s250bcec0iddf1ebdc616e0bbf@mail.gmail.com>
On Sun, 4 Nov 2007, Marco Costalba wrote:
>
> But --early-output does not imply --topo-order, I guess...
Well, it does right now, because I imagined that the primary users would
always want the topological sort.
However, I have to admit that --early-output *could* be used even without
the topological sort, because it also works for other cases that require
up-front limiter logic - things like ranges of commits also have to be
fully evaluated before they are totally certain, so I could imagine seeing
some visualizer some day that doesn't need the topo-order sort, but does
want to get a "preliminary" list.
That said, it does seem unlikely. Anybody who asks for --early-output is
pretty much invariably going to be an interactive visulizer: the whole
notion doesn't make much sense otherwise. So I think I made the right
choice in making --early-output imply topo-order, and if somebody ever
wants to not get the output topologically sorted (unlikely), we could add
a "--no-topo-order" flag.
Side note: if you want the "--date-order", you do need to specify *both*
--early-output and --date-order, and it will do the right thing (ie both
the preliminary output and the final one will be topologically sorted, but
within that topo-sort it will be in date order rather than clumped by
the "shape" of the history).
Linus
next prev parent reply other threads:[~2007-11-04 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 23:49 [RFC PATCH] Make gitk use --early-output Paul Mackerras
2007-11-04 2:07 ` Michael J. Cohen
2007-11-04 5:30 ` Linus Torvalds
2007-11-04 10:37 ` Marco Costalba
2007-11-04 11:04 ` Paul Mackerras
2007-11-04 11:57 ` Marco Costalba
2007-11-04 17:53 ` Linus Torvalds [this message]
2007-11-04 18:28 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0711040947110.15101@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).