git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alex Vandiver <alexmv@dropbox.com>
Cc: git@vger.kernel.org, Ben Peart <peartben@gmail.com>
Subject: Re: [PATCH v3] 0/4 fsmonitor fixes
Date: Sun, 29 Oct 2017 13:34:41 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1.1710291334290.6482@virtualbox> (raw)
In-Reply-To: <20171027232637.30395-1-alexmv@dropbox.com>

Hi Alex,

On Fri, 27 Oct 2017, Alex Vandiver wrote:

> Updates since v2:
> 
>  - Fix tab which crept into 1/4
> 
>  - Fixed the benchmarking code in the commit message in 2/4 to just
>    always load JSON::XS -- the previous version was the version where
>    I'd broken that to force loading of JSON::PP.
> 
>  - Remove the --no-pretty from the t/ version of query-watchman in
>    2/4; I don't know how I messed up diff'ing the file previously, but
>    if there are already differences, it makes sense to let them slide.

Sounds good!
Dscho

  parent reply	other threads:[~2017-10-29 12:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 23:26 [PATCH v3] 0/4 fsmonitor fixes Alex Vandiver
2017-10-27 23:26 ` [PATCH v3 1/4] fsmonitor: Set the PWD to the top of the working tree Alex Vandiver
2017-10-27 23:26   ` [PATCH v3 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman Alex Vandiver
2017-10-27 23:26   ` [PATCH v3 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR Alex Vandiver
2017-10-27 23:26   ` [PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged Alex Vandiver
2017-10-31  5:24     ` Junio C Hamano
2017-10-31 17:31       ` Johannes Schindelin
2017-10-31 18:43         ` Alex Vandiver
2017-10-29 12:34 ` Johannes Schindelin [this message]
2017-10-30 12:38 ` [PATCH v3] 0/4 fsmonitor fixes Ben Peart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1.1710291334290.6482@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=alexmv@dropbox.com \
    --cc=git@vger.kernel.org \
    --cc=peartben@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).