From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Brandon Tolsch <btolsch@gmail.com>,
Vasco Almeida <vascomalmeida@sapo.pt>,
git@vger.kernel.org
Subject: Re: [PATCH] rebase--interactive: count squash commits above 10 correctly
Date: Sat, 7 Jan 2017 11:51:23 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1701071150490.3469@virtualbox> (raw)
In-Reply-To: <20170107082318.jj3izthx2ylscrns@sigill.intra.peff.net>
Hi Peff,
On Sat, 7 Jan 2017, Jeff King wrote:
> On Fri, Jan 06, 2017 at 01:04:05AM -0800, Brandon Tolsch wrote:
>
> We can fix this by making the ".*" less greedy. Instead of
> depending on ".*?" working portably, we can just limit the
> match to non-digit characters, which accomplishes the same
> thing.
Or we could simply require a space before the first digit, which would
maybe look a little simpler.
Ciao,
Dscho
next prev parent reply other threads:[~2017-01-07 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 9:04 Squashing commits with git rebase -i may miscount commits in commit message Brandon Tolsch
2017-01-06 13:46 ` Johannes Schindelin
2017-01-07 8:23 ` [PATCH] rebase--interactive: count squash commits above 10 correctly Jeff King
2017-01-07 10:51 ` Johannes Schindelin [this message]
2017-01-07 11:05 ` Jeff King
2017-01-08 3:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701071150490.3469@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=btolsch@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=vascomalmeida@sapo.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).