From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Rich Felker <email@example.com> Cc: Jeff King <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: Regression: git no longer works with musl libc's regex impl Date: Tue, 4 Oct 2016 18:08:33 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1610041802310.35196@virtualbox> (raw) In-Reply-To: <20161004154045.GT19318@brightrain.aerifal.cx> Hi Rich, On Tue, 4 Oct 2016, Rich Felker wrote: > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote: > > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote: > > > > > 1. is nonzero mod page size, it just works; the remainder of the last > > > page reads as zero bytes when mmapped. > > > > Is that a portable assumption? > > Yes. No, it is not. You quote POSIX, but the matter of the fact is that we use a subset of POSIX in order to be able to keep things running on Windows. And quite honestly, there are lots of reasons to keep things running on Windows, and even to favor Windows support over musl support. Over four million reasons: the Git for Windows users. So rather than getting into an ideological discussion about "broken" systems, it would be good to keep things practical, realizing that those users make up a very real chunk of all of Git's users. As to making NO_REGEX conditional on REG_STARTEND: you are talking about apples and oranges here. NO_REGEX is a Makefile flag, while REG_STARTEND is a C preprocessor macro. Unless you can convince the rest of the Git developers (you would not convince me) to simulate autoconf by compiling an executable every time `make` is run, to determine whether REG_STARTEND is defined, this is a no-go. However, you *can* use autoconf directly, and come up with a patch to our configure.ac that detects the absence of REG_STARTEND and sets NO_REGEX=1. Alternatively, you can set NO_REGEX=1 in your config.mak. Or, if you use one of the auto-detected cases in config.mak.uname, you could patch it to set NO_REGEX=1. And lastly, the best alternative would be to teach musl about REG_STARTEND, as it is rather useful a feature. Ciao, Johannes
next prev parent reply other threads:[~2016-10-04 16:08 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-04 15:08 Rich Felker 2016-10-04 15:27 ` Jeff King 2016-10-04 15:40 ` Rich Felker 2016-10-04 16:08 ` Johannes Schindelin [this message] 2016-10-04 16:11 ` Rich Felker 2016-10-04 17:16 ` Johannes Schindelin 2016-10-04 18:00 ` Ray Donnelly 2016-10-04 17:39 ` [musl] " Rich Felker 2016-10-05 11:17 ` Johannes Schindelin 2016-10-05 13:01 ` Szabolcs Nagy 2016-10-05 13:15 ` Rich Felker 2016-10-04 22:06 ` James B 2016-10-04 22:33 ` Rich Felker 2016-10-04 22:48 ` Junio C Hamano 2016-10-05 13:11 ` Jakub Narębski 2016-10-05 16:15 ` [musl] " Rich Felker 2016-10-05 10:41 ` Johannes Schindelin 2016-10-05 11:59 ` James B 2016-10-05 16:11 ` Jeff King 2016-10-05 16:27 ` Rich Felker 2016-10-06 10:44 ` Johannes Schindelin 2016-10-06 19:18 ` Ævar Arnfjörð Bjarmason 2016-10-06 19:23 ` Jeff King 2016-10-06 19:25 ` Rich Felker 2016-10-06 19:28 ` Jeff King 2016-10-06 22:42 ` Ramsay Jones 2016-10-07 11:30 ` Jakub Narębski 2016-10-04 16:01 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.20.1610041802310.35196@virtualbox \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Regression: git no longer works with musl libc'\''s regex impl' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).