From: Alex Vandiver <alexmv@dropbox.com>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman
Date: Thu, 26 Oct 2017 14:29:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1710261427300.9817@alexmv-linux> (raw)
In-Reply-To: <9bd24b15-6232-1afd-abbe-02870c51c7ad@gmail.com>
On Thu, 26 Oct 2017, Ben Peart wrote:
> On 10/25/2017 9:31 PM, Alex Vandiver wrote:
> > diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
> > index a3e30bf54..79f24325c 100755
> > --- a/t/t7519/fsmonitor-watchman
> > +++ b/t/t7519/fsmonitor-watchman
> > @@ -50,7 +50,7 @@ launch_watchman();
> > sub launch_watchman {
> > - my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j')
> > + my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty')
>
> Since this is a test script performance isn't critical. This version of the
> integration script logs the response to a file in .git/watchman-response.json
> and is much more human readable without the "--no-pretty." As such, I'd leave
> this one pretty.
This would be the first delta between the test file and the template
file. It seems quite important to me to attempt to ensure that we're
testing the _same_ contents that we're suggesting users set up. In
fact, it makes more sense to me to just turn this into a symlink to the
sample template.
- Alex
next prev parent reply other threads:[~2017-10-26 21:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 1:31 [PATCH v2 0/4] fsmonitor fixes Alex Vandiver
2017-10-26 1:31 ` [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree Alex Vandiver
2017-10-26 1:31 ` [PATCH v2 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman Alex Vandiver
2017-10-26 20:05 ` Ben Peart
2017-10-26 20:32 ` Ben Peart
2017-10-26 21:29 ` Alex Vandiver [this message]
2017-10-27 3:36 ` Ben Peart
2017-10-26 1:31 ` [PATCH v2 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR Alex Vandiver
2017-10-26 1:31 ` [PATCH v2 4/4] fsmonitor: Delay updating state until after split index is merged Alex Vandiver
2017-10-26 20:29 ` Ben Peart
2017-10-26 1:33 ` [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree Alex Vandiver
2017-10-26 19:56 ` Ben Peart
2017-10-26 21:27 ` Alex Vandiver
2017-10-27 3:40 ` Ben Peart
2017-10-27 23:20 ` Alex Vandiver
2017-10-29 12:27 ` Johannes Schindelin
2017-10-29 12:31 ` [PATCH v2 0/4] fsmonitor fixes Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1710261427300.9817@alexmv-linux \
--to=alexmv@dropbox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).