From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Frank Li <lznuaa@gmail.com>
Cc: git@vger.kernel.org, msysGit <msysgit@googlegroups.com>
Subject: Re: Using VC build git (new patch)
Date: Sat, 15 Aug 2009 18:57:55 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0908151851280.8306@pacific.mpi-cbg.de> (raw)
In-Reply-To: <1976ea660908150921n516178dbs2ce024ed729e2e02@mail.gmail.com>
Hi,
On Sun, 16 Aug 2009, Frank Li wrote:
> New patch.
A single monster patch?
Hmm.
Please understand that I will not review that unless it is split up into
nice little and reviewable chunks.
This diffstat does not let me expect well-defined changes, either, sorry:
builtin-fast-export.c | 1 +
compat/fnmatch/fnmatch.c | 2 +
compat/mingw.c | 68 ++-
compat/mingw.h | 21 +-
compat/regex/regex.c | 8 +-
compat/snprintf.c | 7 +-
compat/vcbuild/.gitignore | 3 +
compat/vcbuild/ReadMe | 13 +
compat/vcbuild/git/git.vcproj | 197 +++++
compat/vcbuild/include/dirent.h | 127 ++++
compat/vcbuild/include/unistd.h | 174 +++++
compat/vcbuild/libgit/libgit.vcproj | 1347 +++++++++++++++++++++++++++++++++++
compat/vcbuild/porting.c | 13 +
compat/vcbuild/sys/time.h | 21 +
compat/winansi.c | 8 +
git-compat-util.h | 2 +-
help.c | 5 +-
pager.c | 4 +-
run-command.c | 11 +-
run-command.h | 2 +-
setup.c | 2 +-
21 files changed, 2011 insertions(+), 25 deletions(-)
It still modifies mingw.c and mingw.h, even if it has been strongly
suggested to leave those alone.
It touches all kinds of files that appear to be completely unrelated to
Microsoft Visual C++.
Remember: breaking things for existing users (and changing something that
works for them quite well readily risks that) is not an option.
And the commit message does not even explain half of it...
Ciao,
Dscho
next prev parent reply other threads:[~2009-08-15 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 16:21 Using VC build git (new patch) Frank Li
2009-08-15 16:57 ` Johannes Schindelin [this message]
2009-08-15 17:29 ` Johannes Schindelin
2009-08-16 4:07 ` Frank Li
2009-08-16 8:38 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0908151851280.8306@pacific.mpi-cbg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).