From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, blanet <bupt_xingxin@163.com>,
Xing Xin <xingxin.xx@bytedance.com>,
blanet via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH v2] midx: disable replace objects
Date: Thu, 18 Apr 2024 09:22:03 -0400 [thread overview]
Message-ID: <ZiEee8ySuy6kCvBZ@nand.local> (raw)
In-Reply-To: <xmqqplun6aws.fsf@gitster.g>
On Wed, Apr 17, 2024 at 12:34:27PM -0700, Junio C Hamano wrote:
> "blanet via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Xing Xin <xingxin.xx@bytedance.com>
> > ...
> > Helped-by: Taylor Blau <me@ttaylorr.com>
> > Signed-off-by: Xing Xin <xingxin.xx@bytedance.com>
> > ---
>
> I think this took the review in
>
> https://lore.kernel.org/git/ZhLfqU9VNUW+2mmV@nand.local/
>
> into account and is in good shape?
Yes, sorry for not explicitly ack-ing, this version looks good to me.
Thanks,
Taylor
next prev parent reply other threads:[~2024-04-18 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 13:11 [PATCH] midx: disable replace objects blanet via GitGitGadget
2024-04-07 14:16 ` Taylor Blau
2024-04-07 18:02 ` Taylor Blau
2024-04-07 18:04 ` Taylor Blau
2024-04-08 5:45 ` [External] " 鑫邢
2024-04-08 5:26 ` [PATCH v2] " blanet via GitGitGadget
2024-04-17 19:34 ` Junio C Hamano
2024-04-18 13:22 ` Taylor Blau [this message]
2024-04-18 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiEee8ySuy6kCvBZ@nand.local \
--to=me@ttaylorr.com \
--cc=bupt_xingxin@163.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=xingxin.xx@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).