From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] pack-bitmap: gracefully handle missing BTMP chunks
Date: Tue, 16 Apr 2024 07:14:00 +0200 [thread overview]
Message-ID: <Zh4JGJm6cYFjk4x_@tanuki> (raw)
In-Reply-To: <20240416051232.GA1745631@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On Tue, Apr 16, 2024 at 01:12:32AM -0400, Jeff King wrote:
> On Tue, Apr 16, 2024 at 06:47:51AM +0200, Patrick Steinhardt wrote:
>
> > > > + GIT_TEST_MIDX_READ_BTMP=false git -c pack.allowPackReuse=$allow_pack_reuse \
> > > > + pack-objects --all --use-bitmap-index --stdout </dev/null >/dev/null 2>err &&
> > >
> > > A small note here, but setting stdin to read from /dev/null is
> > > unnecessary with `--all.`
> >
> > Is it really? Executing `git pack-objects --all --stdout` on my system
> > blocks until stdin is closed. It _seems_ to work in the tests alright,
> > but doesn't work outside of them. Which is puzzling on its own.
>
> Inside a test_expect block, stdin is already redirected from /dev/null.
> See 781f76b158 (test-lib: redirect stdin of tests, 2011-12-15).
>
> I do think it's still good practice to redirect from /dev/null
> explicitly to indicate the intent.
Ah, that explains. Thanks!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-04-16 5:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 5:59 [PATCH] pack-bitmap: gracefully handle missing BTMP chunks Patrick Steinhardt
2024-04-10 15:02 ` Taylor Blau
2024-04-15 6:34 ` Patrick Steinhardt
2024-04-15 22:42 ` Taylor Blau
2024-04-15 6:41 ` [PATCH v2] " Patrick Steinhardt
2024-04-15 8:51 ` Patrick Steinhardt
2024-04-15 17:41 ` Junio C Hamano
2024-04-15 22:51 ` Taylor Blau
2024-04-15 23:46 ` Junio C Hamano
2024-04-15 22:51 ` Taylor Blau
2024-04-16 4:47 ` Patrick Steinhardt
2024-04-16 5:12 ` Jeff King
2024-04-16 5:14 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh4JGJm6cYFjk4x_@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).