git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2024, #01; Mon, 1)
Date: Mon, 1 Apr 2024 17:17:53 -0400	[thread overview]
Message-ID: <Zgskgeg6kXJsb3/c@nand.local> (raw)
In-Reply-To: <xmqq4jckaoid.fsf@gitster.g>

Hi Junio,

Thanks as always for preparing these. I have comments on the two topics
with my name on them below, but I wanted to make sure that the series at
<cover.1711387439.git.me@ttaylorr.com> is on your radar.

This is the one to move writing-related functions from 'midx.c' into a
new 'midx-write.c'.

I just sent a reroll here <cover.1712006190.git.me@ttaylorr.com>, which
is based on René's patch as well as incorporates feedback from your and
Peff's review of the first round.

On Mon, Apr 01, 2024 at 12:09:30PM -0700, Junio C Hamano wrote:
> * tb/pseudo-merge-reachability-bitmap (2024-03-20) 24 commits
>
>  The pack-bitmap machinery learned to write pseudo-merge bitmaps,
>  which act as imaginary octopus merges covering un-bitmapped
>  reference tips. This enhances bitmap coverage, and thus,
>  performance, for repositories with many references using bitmaps.
>
>  Expecting a reroll.
>  cf. <ZfyxCLpjbaScIdWA@nand.local>
>  source: <cover.1710972293.git.me@ttaylorr.com>

Thanks updating the description. I am waiting to reroll until after it
has received a little bit of review on the technical front.

> * tb/path-filter-fix (2024-01-31) 16 commits
>
>  The Bloom filter used for path limited history traversal was broken
>  on systems whose "char" is unsigned; update the implementation and
>  bump the format version to 2.
>
>  Waiting for a final ack?
>  cf. <ZcFjkfbsBfk7JQIH@nand.local>
>  source: <cover.1706741516.git.me@ttaylorr.com>

I am not sure what to do with this topic... I haven't heard from
Jonathan Tan in a while, and the same from SZEDER Gábor, who was also
reviewing it.

I personally think that the topic is in good shape and ready to go, but
I would rather get a concurring opinion from some other reviewers before
suggesting that it be merged.

Thanks,
Taylor


  reply	other threads:[~2024-04-01 21:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 19:09 What's cooking in git.git (Apr 2024, #01; Mon, 1) Junio C Hamano
2024-04-01 21:17 ` Taylor Blau [this message]
2024-04-01 22:09   ` Junio C Hamano
2024-04-01 23:08     ` Junio C Hamano
2024-04-01 23:27       ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zgskgeg6kXJsb3/c@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).