From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 4FB7A1F403 for ; Tue, 4 Oct 2022 07:57:42 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kSJNuBrK"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbiJDH5g (ORCPT ); Tue, 4 Oct 2022 03:57:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiJDH5d (ORCPT ); Tue, 4 Oct 2022 03:57:33 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D65C2CC86 for ; Tue, 4 Oct 2022 00:57:33 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 3so12077443pga.1 for ; Tue, 04 Oct 2022 00:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=39x2lEUHCvkKAj0iTicxVbuc/O9TS7kGC5yWHkEUgQM=; b=kSJNuBrKjZ5opQUmWZK/YrLMXoBvKidBt5npuqE4zGu7joGfPD02nr8nT21x/UxpGE CscJOk4/dyxQXwiq36kkHkyPqud3Z5JxXbSm8Dswd7P2LtqS4Kko4hm4EKdS+nCaCqec WQhdLNdJpLm1u8gjlYzi1N13m3IyjqJhGZq7Ax6+gBeDtB+FsSTZf0aNkA+VaPnto+BQ yrBt9GseEMMl+HwGJZ+xSz6DluGZ5H0QZwdkWWZsI0nrykCwQXvNvu72xFIKebgNglTJ VShjm/iGjxTQRm1d5GcEBRLe470tLDxvRjJkN+dxb00WFmqjg58VzM1tBJAvLnB5aWsp RPEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=39x2lEUHCvkKAj0iTicxVbuc/O9TS7kGC5yWHkEUgQM=; b=5z3Rd3C21U/+gjzNReE14ZnCw5gonw81CJDlv9/d4CWbFPqQDjVaKklkkak0uFjOeo 7/AHnhYur7DslpNolF+SkDVOvKVNCCLjyhDidwTU+6Ec0Rio+BC/PHQ43JlTyhH1u6tQ bGGLM31PIpNayb3lPVv762tewFkA8Nc6aYf+GQv040FZpSIIAzDjwUMJ8SKQwkyYpoie LcN17VYQ6rQcFwp/tunLZf0wJ0IPlBnxKnY4i+v3k2qPBJHp/uyBRNw0vqOOPPJkNV8s 1n0sgLEPIRDGWUL5pMYSLuZbbe2/uzEXu2mwuOgdQdpyy39q/scCZQPYExn/enC2VSD/ eLYQ== X-Gm-Message-State: ACrzQf1UVX4IRynBGfXIDLdMePH40ut27Dd0/QzIesafjKDcWVpIrBC6 CScl205sSP4B8fsaxNG34YJAZG1uPQ0= X-Google-Smtp-Source: AMsMyM7/GRP1uIsQWJVUiC6Bir1J//H0skV2Y6gbCpT02N7Kvh3rTKhfHwu4paZi1ETwcbNzGnw24g== X-Received: by 2002:a63:cc43:0:b0:43a:2f12:d326 with SMTP id q3-20020a63cc43000000b0043a2f12d326mr22177151pgi.320.1664870252849; Tue, 04 Oct 2022 00:57:32 -0700 (PDT) Received: from localhost ([2001:ee0:500b:6370:da47:cda5:dbd5:6e77]) by smtp.gmail.com with ESMTPSA id h70-20020a628349000000b0052d98fbf8f3sm5977521pfe.56.2022.10.04.00.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 00:57:32 -0700 (PDT) Date: Tue, 4 Oct 2022 14:57:29 +0700 From: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh To: darkdragon Cc: git@vger.kernel.org Subject: Re: Install-prefix when building should not be hardcoded Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2022-10-04 09:38:24+0200, darkdragon wrote: > Even though in Makefile, it is stated that git will figure out > gitexecdir at runtime based on the path to the executable, there are > many output files where $(prefix) will be hardcoded. Even git > --exec-path will print out $(compile_prefix)/libexec/git-core instead > of using run_prefix. I'm not sure about this part. > Example: We are building git in Docker at a separate stage to /deploy > (since /usr/local is populated with our compiler toolchain). The final > image is assembled by copying the contents of /deploy to /usr/local. > Commands like "git submodule" will fail because of the wrong git exec > path. Searching via "grep -r /deploy" in /deploy after make install > yields many results. But you may be interested in $(DESTDIR) make prefix=/usr/local all make prefix=/usr/local DESTDIR=/deploy install Does that work for you? -- Danh