From: Jeff King <peff@peff.net>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Atharva Raykar <raykar.ath@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git.git (Oct 2021, #06; Mon, 25)
Date: Mon, 1 Nov 2021 00:04:57 -0400 [thread overview]
Message-ID: <YX9naXglQIDYa0jg@coredump.intra.peff.net> (raw)
In-Reply-To: <1575aeb5-7aec-3d5c-6b2c-11b9866f3f4c@gmail.com>
On Mon, Nov 01, 2021 at 12:06:20AM +0530, Kaartic Sivaraam wrote:
> > This commit has an extra unused parameter in the helper function. I
> > think we'd want the patch below on top.
> >
>
> Sorry for the oversight and thanks for catching it (again)!
>
> This reminded me to check my config.mak and enable DEVELOPER=1
> which I seem to have turned off for some reason. I did notice
> we explicitly add -Wno-unused-parameter to DEVELOPER_CFLAGS (likely
> with good reason). The rest of the flags should be helpful though :)
Yes, there are hundreds of false positives for -Wunused-parameter. I
have a series annotating all of them (which is indeed how I found the
problem fixed here), but I haven't quite gotten around to cleaning them
all up. (Plus I've been a little afraid to flood the list with them).
-Peff
next prev parent reply other threads:[~2021-11-01 4:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 3:48 What's cooking in git.git (Oct 2021, #06; Mon, 25) Junio C Hamano
2021-10-26 5:25 ` Jeff King
2021-10-27 17:42 ` Junio C Hamano
2021-10-31 18:36 ` Kaartic Sivaraam
2021-11-01 4:04 ` Jeff King [this message]
2021-10-26 11:02 ` pre-v2.34.0-rc0 regressions: t7900-maintenance.sh broken due to 'systemd-analyze' (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 15:34 ` Ævar Arnfjörð Bjarmason
2021-10-26 18:43 ` Eric Sunshine
2021-11-02 14:24 ` [PATCH] maintenance tests: fix systemd v2.34.0-rc* test regression Ævar Arnfjörð Bjarmason
2021-11-03 5:09 ` Eric Sunshine
2021-11-10 3:52 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-11-10 13:36 ` Johannes Schindelin
2021-11-10 16:22 ` Ævar Arnfjörð Bjarmason
2021-11-11 17:45 ` Junio C Hamano
2021-10-26 11:15 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-27 11:14 ` Jeff King
2021-10-27 18:04 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning Junio C Hamano
2021-10-28 17:30 ` Jeff King
2021-10-28 19:02 ` Junio C Hamano
2021-10-28 19:17 ` Jeff King
2021-10-26 12:13 ` tb/plug-pack-bitmap-leaks (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 21:04 ` Taylor Blau
2021-10-26 12:17 ` jc/branch-copy-doc " Ævar Arnfjörð Bjarmason
2021-10-26 12:42 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Derrick Stolee
2021-10-26 14:55 ` Ævar Arnfjörð Bjarmason
2021-10-26 17:27 ` Victoria Dye
2021-10-26 21:29 ` Junio C Hamano
2021-10-26 21:28 ` Junio C Hamano
2021-10-26 21:54 ` Derrick Stolee
2021-10-26 22:21 ` regression in ns/tmp-objdir and ns/batched-fsync Neeraj Singh
2021-10-27 19:17 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Martin Ågren
2021-10-28 0:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX9naXglQIDYa0jg@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=raykar.ath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).