From: Son Luong Ngoc <sluongng@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, avarab@gmail.com, jonathantanmy@google.com,
gitster@pobox.com
Subject: Re: Tests failed with GIT_TEST_FAIL_PREREQS and/or GIT_TEST_PROTOCOL_VERSION
Date: Wed, 17 Mar 2021 14:38:18 +0100 [thread overview]
Message-ID: <YFIGSo3U5u7zy9fq@C02YX140LVDN.corpad.adbkng.com> (raw)
In-Reply-To: <YFC33vfLb36pRCO6@nand.local>
Hi Taylor,
On Tue, Mar 16, 2021 at 09:52:47AM -0400, Taylor Blau wrote:
> Hi,
>
> Is it possible that your bisection script doesn't report success
> properly? Bisecting the same range (v2.30.0..v2.31.0) with
>
> $ cat run.sh
> #!/bin/sh
> false
>
> does say that my 3b1ca60f8f (ewah/ewah_bitmap.c: avoid open-coding
> ALLOC_GROW(), 2020-12-08) is the first bad commit.
You are spot on. It was a busy day and I only had a few minutes to
look at our internal pipeline of the test suite. I guess I was doing
something along the line of.
$ git bisect start HEAD v2.30.0
$ git bisect run 'cd t && GIT_TEST_PROTOCOL_VERSION=1 ./t5606-clone-options.sh'
Which does indeed errored out and pointed to your commit.
>
> Thanks,
> Taylor
I have properly re-run the bisection in a './test.sh' bash script and
here are the suspicious commits:
1. For t7810 and t5300 failing when GIT_TEST_FAIL_PREREQS=1:
a926c4b904bdc339568c2898af955cdc61b31542 is the first bad commit
commit a926c4b904bdc339568c2898af955cdc61b31542
Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu Feb 11 02:53:51 2021 +0100
tests: remove most uses of C_LOCALE_OUTPUT
As a follow-up to d162b25f956 (tests: remove support for
GIT_TEST_GETTEXT_POISON, 2021-01-20) remove those uses of the now
always true C_LOCALE_OUTPUT prerequisite from those tests which
declare it as an argument to test_expect_{success,failure}.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2. For failing t5606 while 'GIT_TEST_PROTOCOL_VERSION=1' was used:
4f37d45706514a4b3d0259d26f719678a0cf3521 is the first bad commit
commit 4f37d45706514a4b3d0259d26f719678a0cf3521
Author: Jonathan Tan <jonathantanmy@google.com>
Date: Fri Feb 5 12:48:49 2021 -0800
clone: respect remote unborn HEAD
Teach Git to use the "unborn" feature introduced in a previous patch as
follows: Git will always send the "unborn" argument if it is supported
by the server. During "git clone", if cloning an empty repository, Git
will use the new information to determine the local branch to create. In
all other cases, Git will ignore it.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/config/init.txt | 2 +-
builtin/clone.c | 16 ++++++++++++++--
connect.c | 28 ++++++++++++++++++++++++++--
t/t5606-clone-options.sh | 8 +++++---
t/t5702-protocol-v2.sh | 25 +++++++++++++++++++++++++
transport.h | 8 ++++++++
6 files changed, 79 insertions(+), 8 deletions(-)
Thanks,
Son Luong.
next prev parent reply other threads:[~2021-03-17 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 9:45 Tests failed with GIT_TEST_FAIL_PREREQS and/or GIT_TEST_PROTOCOL_VERSION Son Luong Ngoc
2021-03-16 13:52 ` Taylor Blau
2021-03-17 13:38 ` Son Luong Ngoc [this message]
2021-03-17 15:42 ` [PATCH] t5606: run clone branch name test with protocol v2 Jonathan Tan
2021-03-17 17:42 ` Jeff King
2021-03-17 18:18 ` Junio C Hamano
2021-03-17 17:54 ` Tests failed with GIT_TEST_FAIL_PREREQS and/or GIT_TEST_PROTOCOL_VERSION Jeff King
2021-03-17 22:47 ` [PATCH] t: annotate !PTHREADS tests with !FAIL_PREREQS Jeff King
2021-03-18 21:17 ` Junio C Hamano
2021-03-18 21:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFIGSo3U5u7zy9fq@C02YX140LVDN.corpad.adbkng.com \
--to=sluongng@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).