From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: Yaron Wittenstein <yaron.wittenstein@gmail.com>, git@vger.kernel.org
Subject: Re: [QUESTION] Tracking HEAD changes?
Date: Fri, 26 Feb 2021 00:59:56 -0500 [thread overview]
Message-ID: <YDiOXDbN/JtUWgWu@coredump.intra.peff.net> (raw)
In-Reply-To: <YDc3dinQ37FY8fhD@ncase>
On Thu, Feb 25, 2021 at 06:36:54AM +0100, Patrick Steinhardt wrote:
> > Hmm, I would have thought that the branch switch would trigger the hooks
> > because they're updating HEAD. I wonder if that is a bug (or lack of
> > feature :) ) in the transaction hooks, or something Patrick did
> > intentionally.
>
> It was done semi-intentionally, or at least with the knowledge that
> symrefs aren't covered. This is mostly because they're not covered by
> the reference transaction mechanism itself.
Ah, right, I forgot about that. That might be something that we'd want
to fix if anybody wanted to use the transaction hooks to track the
complete state of refs.
At GitHub, our repository replication does track symbolic ref updates,
but we handle it outside of Git. Our normal ref updates use a few custom
bits of code similar to your transaction hooks in order to implement a
3-phase commit. But our symref updates don't; they just take a lock, run
git-symbolic-ref on each, and then vote on the result. This is slower
and less robust, but symbolic ref updates are relatively rare, so it
hasn't been a big deal.
-Peff
next prev parent reply other threads:[~2021-02-26 6:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:12 [QUESTION] Tracking HEAD changes? Yaron Wittenstein
2021-02-23 0:38 ` Jeff King
2021-02-23 20:42 ` Jeff King
2021-02-24 20:21 ` Yaron Wittenstein
2021-02-24 21:03 ` Jeff King
2021-02-25 5:36 ` Patrick Steinhardt
2021-02-25 6:01 ` Yaron Wittenstein
2021-02-25 6:27 ` Patrick Steinhardt
2021-02-25 7:13 ` Junio C Hamano
2021-02-25 7:28 ` Patrick Steinhardt
2021-02-25 7:50 ` Yaron Wittenstein
2021-02-26 5:59 ` Jeff King [this message]
2021-02-26 20:58 ` Yaron Wittenstein
2021-03-01 9:03 ` Jeff King
2021-03-01 10:02 ` Yaron Wittenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDiOXDbN/JtUWgWu@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=yaron.wittenstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).