From: Jeff King <peff@peff.net>
To: Utku Gultopu via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Utku Gultopu <ugultopu@gmail.com>
Subject: Re: [PATCH] doc: `--date` in `git-commit` accepts approxidates
Date: Tue, 23 Feb 2021 13:11:53 -0500 [thread overview]
Message-ID: <YDVFaTGnPCfuJQSa@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.969.git.git.1614101746491.gitgitgadget@gmail.com>
On Tue, Feb 23, 2021 at 05:35:46PM +0000, Utku Gultopu via GitGitGadget wrote:
> From: Utku Gultopu <ugultopu@gmail.com>
>
> Document the fact that the `--date` option in `git-commit` accepts any
> date format that is accepted by the `approxidate_careful` function,
> which is located in `date.c`.
I agree it's worth documenting this a bit better, but...
> I guess this patch is not ideal, because instead of properly
> documenting, it refers the user to the code. However I wasn't able to
> find documentation about the "approxidates" which I can link to. Please
> let me know how I can improve it.
...yeah. I don't think the phrase "approxidate_careful" is really
meaningful to end users.
Perhaps we can leave this hunk intact:
> +DATE FORMATS[[DATES]]
> +---------------------
>
> -The `GIT_AUTHOR_DATE`, `GIT_COMMITTER_DATE` environment variables
> -ifdef::git-commit[]
> -and the `--date` option
> -endif::git-commit[]
> +The `GIT_AUTHOR_DATE` and `GIT_COMMITTER_DATE` environment variables
> support the following date formats:
since it's true that --date does accept those formats.
And then at the end of that section, expand what it's willing to take:
ifdef::git-commit[]
The `--date` option (but not the environment variables) will also try to
make sense of other more human-centric date formats, including relative
dates like "yesterday" or "last Friday at noon".
endif::git-commit[]
-Peff
next prev parent reply other threads:[~2021-02-23 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 17:35 [PATCH] doc: `--date` in `git-commit` accepts approxidates Utku Gultopu via GitGitGadget
2021-02-23 18:11 ` Jeff King [this message]
2021-02-23 19:33 ` Junio C Hamano
2021-02-23 18:52 ` [PATCH v2] " Utku Gultopu via GitGitGadget
2021-02-23 19:06 ` Jeff King
[not found] ` <CAEeqB6kqZTft9NWtOvm3hk9bicBL7GU_WYuAGdMG1MHYMgNAxg@mail.gmail.com>
2021-02-23 19:16 ` Utku
2021-02-23 19:34 ` Junio C Hamano
2021-02-23 20:24 ` Utku
2021-02-23 20:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDVFaTGnPCfuJQSa@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ugultopu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).