From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C85FD1F9FC for ; Mon, 8 Feb 2021 23:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231483AbhBHXoC (ORCPT ); Mon, 8 Feb 2021 18:44:02 -0500 Received: from injection.crustytoothpaste.net ([192.241.140.119]:44384 "EHLO injection.crustytoothpaste.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhBHXns (ORCPT ); Mon, 8 Feb 2021 18:43:48 -0500 Received: from camp.crustytoothpaste.net (castro.crustytoothpaste.net [75.10.60.170]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by injection.crustytoothpaste.net (Postfix) with ESMTPSA id 3D2BC60B19; Mon, 8 Feb 2021 23:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1612827786; bh=tQPDnp13Asvt9kqmCFfiMVxYUALlNrIBnuXkoFSAOpU=; h=Date:From:To:Cc:Subject:References:Content-Type: Content-Disposition:In-Reply-To:From:Reply-To:Subject:Date:To:CC: Resent-Date:Resent-From:Resent-To:Resent-Cc:In-Reply-To:References: Content-Type:Content-Disposition; b=x6nGlv8ptoFxC+FaSQ8oRkGfSEQMvT1Gyyb45p0nMbkJmaGUkKYBPtM6ZzTDmiGgn bvhOm0mGkjbBpY4ohUs/tTO60tYfaGTb8/TnoIgKropKFJ59+kRSa3a1mxruqFURUa DbTEexIl4w/FxLibvNrOyqxUCH2gBGvSCXdWsnPXuG22yzadsZIaYvvYrasfH2A2N7 lrIfwgqyxFYSjnKjzgLdsgtoo/oCMYhhcLb2lqbvl9q4KncmwK3dh3AE+JzTCmnysD lK3ASaoP+fWonx8vzcNZO7x870tlHV1Jtxb/mlxzaTSm/dgikLEn8aSQt0mZLplrWb gxXAvVTsZgsmOiDhXxSW0yfwRGMydHaxwUsYQ+mdapP08zJWHj1AT1ZblD72ZIwDan /L8bKUZUJmp24osyYXWaLF/IqOas9+UV9zYHMaIDWjqgxb7V4D67g1WEcNAOQADTI8 tuncobrlYRptyvTxNLLSRuPvYnlzrcbdb28OixbqNp/21Gfr8Bz Date: Mon, 8 Feb 2021 23:43:01 +0000 From: "brian m. carlson" To: Junio C Hamano Cc: Hariom verma , Hariom Verma via GitGitGadget , git , Christian Couder , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH v3 3/3] ref-filter: use pretty.c logic for trailers Message-ID: Mail-Followup-To: "brian m. carlson" , Junio C Hamano , Hariom verma , Hariom Verma via GitGitGadget , git , Christian Couder , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason References: <47d89f872314cad6dc6010ff3c8ade43a70bc540.1612602945.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Zuqa7doNUBIYkQp+" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org --Zuqa7doNUBIYkQp+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-02-08 at 19:54:18, Junio C Hamano wrote: > Junio C Hamano writes: >=20 > > By the way, when merged to 'seen' (you can try the above that shows > > %(subject) followed by %(trailers) with the tip of 'seen'), it dies > > like this: > > > > $ git for-each-ref \ > > --format=3D"%(subject)%0a%(trailers:key=3DSigned-off-by:)" \ > > refs/heads/js/range-diff-wo-dotdot > > free(): double free detected in tcache 2 > > Aborted > > > > There must be some interaction with another topic but I didn't dig > > deeper. >=20 > It seems brian's bc/signed-objects-with-both-hashes topic alone has > the double-free issue, without the "trailers" topic. >=20 > $ git checkout --detach bc/signed-objects-with-both-hashes > $ make git > $ ./git for-each-ref --format=3D'%(subject)%(body)' refs/heads/maint > free(): double free detected in tcache 2 > Aborted >=20 > So for now, you do not have to worry about it in your topic. Of > course, you are very much welcome to help debugging and fixing it > ;-) I'll take a look. Thanks for the heads up. --=20 brian m. carlson (he/him or they/them) Houston, Texas, US --Zuqa7doNUBIYkQp+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.2.20 (GNU/Linux) iHUEABYKAB0WIQQILOaKnbxl+4PRw5F8DEliiIeigQUCYCHMhQAKCRB8DEliiIei gRSOAQDuakq723WitB3RKdurpVZBhRwbeSs130IJvYdjjx3kfgD9E4YZCaCB4+ps SIqH/ud+7JHvyIm9JQteKke/VcZilwM= =QIvZ -----END PGP SIGNATURE----- --Zuqa7doNUBIYkQp+--