From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Denton Liu <liu.denton@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 0/5] Support for commits signed by multiple algorithms
Date: Tue, 12 Jan 2021 02:24:41 +0000 [thread overview]
Message-ID: <X/0IaVkxqbYxKJBf@camp.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqft366her.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]
On 2021-01-12 at 02:03:08, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > I just noticed this because I'm now getting to the case where we write
> > (and sign) both SHA-1 and SHA-256 versions of commits and I thought I'd
> > better send in a patch sooner rather than later, since there's a lot
> > more prep work (surprise) before we get to anything interesting.
>
> Uncomfortably excited to hear this ;-)
Here's a brief summary of what's ahead:
* struct object_id is going to have an algorithm member.
* Consequently, there will be per-algorithm null OIDs.
* To efficiently compare and copy OIDs of all sizes (notably in khash
tables, where things otherwise become tricky), we'll zero-pad SHA-1
OIDs and always compare the full buffer.
* For all of these reasons, oidread (or similar) will become practically
required.
* Objects will be mapped into the loose object store when written, and
each type of object will have a function to convert it between formats
if required.
* The testsuite will learn a mode not to stuff invalid OIDs into things,
since those will no longer work (because those OIDs can't be mapped
and so we can't create SHA-1 versions of them). That will necessitate
another large set of prerequisite additions in the testsuite.
In progress work can be seen on the transition-interop branch at
https://github.com/bk2204/git.git. I should point out that it is very
in progress; the tip will definitely fail the testsuite in certain
cases.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2021-01-12 2:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 0:37 [PATCH 0/5] Support for commits signed by multiple algorithms brian m. carlson
2021-01-11 0:37 ` [PATCH 1/5] commit: ignore additional signatures when parsing signed commits brian m. carlson
2021-01-11 0:37 ` [PATCH 2/5] gpg-interface: improve interface for parsing tags brian m. carlson
2021-01-12 4:58 ` Junio C Hamano
2021-01-14 23:18 ` brian m. carlson
2021-01-15 1:47 ` Junio C Hamano
2021-01-11 0:37 ` [PATCH 3/5] commit: allow parsing arbitrary buffers with headers brian m. carlson
2021-01-11 0:37 ` [PATCH 4/5] ref-filter: hoist signature parsing brian m. carlson
2021-01-11 0:37 ` [PATCH 5/6] fixup! commit: ignore additional signatures when parsing signed commits brian m. carlson
2021-01-11 0:43 ` brian m. carlson
2021-01-11 0:37 ` [PATCH 5/5] gpg-interface: remove other signature headers before verifying brian m. carlson
2021-01-11 0:37 ` [PATCH 6/6] " brian m. carlson
2021-01-11 3:58 ` [PATCH v2 0/5] Support for commits signed by multiple algorithms brian m. carlson
2021-01-11 3:58 ` [PATCH v2 1/5] commit: ignore additional signatures when parsing signed commits brian m. carlson
2021-01-12 17:03 ` SZEDER Gábor
2021-01-11 3:58 ` [PATCH v2 2/5] gpg-interface: improve interface for parsing tags brian m. carlson
2021-01-12 5:24 ` Junio C Hamano
2021-01-11 3:58 ` [PATCH v2 3/5] commit: allow parsing arbitrary buffers with headers brian m. carlson
2021-01-11 3:58 ` [PATCH v2 4/5] ref-filter: hoist signature parsing brian m. carlson
2021-01-11 3:58 ` [PATCH v2 5/5] gpg-interface: remove other signature headers before verifying brian m. carlson
2021-01-11 22:16 ` [PATCH v2 0/5] Support for commits signed by multiple algorithms Junio C Hamano
2021-01-11 23:29 ` brian m. carlson
2021-01-12 2:03 ` Junio C Hamano
2021-01-12 2:24 ` brian m. carlson [this message]
2021-01-18 23:49 ` [PATCH v3 0/6] " brian m. carlson
2021-01-18 23:49 ` [PATCH v3 1/6] ref-filter: switch some uses of unsigned long to size_t brian m. carlson
2021-01-18 23:49 ` [PATCH v3 2/6] commit: ignore additional signatures when parsing signed commits brian m. carlson
2021-01-18 23:49 ` [PATCH v3 3/6] gpg-interface: improve interface for parsing tags brian m. carlson
2021-01-18 23:49 ` [PATCH v3 4/6] commit: allow parsing arbitrary buffers with headers brian m. carlson
2021-01-18 23:49 ` [PATCH v3 5/6] ref-filter: hoist signature parsing brian m. carlson
2021-01-18 23:49 ` [PATCH v3 6/6] gpg-interface: remove other signature headers before verifying brian m. carlson
2021-02-11 2:08 ` [PATCH v4 0/6] Support for commits signed by multiple algorithms brian m. carlson
2021-02-11 2:08 ` [PATCH v4 1/6] ref-filter: switch some uses of unsigned long to size_t brian m. carlson
2021-02-11 2:08 ` [PATCH v4 2/6] commit: ignore additional signatures when parsing signed commits brian m. carlson
2021-02-11 2:08 ` [PATCH v4 3/6] gpg-interface: improve interface for parsing tags brian m. carlson
2021-02-11 2:08 ` [PATCH v4 4/6] commit: allow parsing arbitrary buffers with headers brian m. carlson
2021-02-11 2:08 ` [PATCH v4 5/6] ref-filter: hoist signature parsing brian m. carlson
2021-02-11 2:08 ` [PATCH v4 6/6] gpg-interface: remove other signature headers before verifying brian m. carlson
2021-02-11 7:45 ` [PATCH v4 0/6] Support for commits signed by multiple algorithms Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/0IaVkxqbYxKJBf@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).