From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make git compile with SUNs forte12 compiler
Date: Sun, 13 May 2007 12:39:41 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705131238420.6410@racer.site> (raw)
In-Reply-To: <11790057101792-git-send-email-sithglan@stud.uni-erlangen.de>
Hi,
On Sat, 12 May 2007, Thomas Glanzmann wrote:
> This patch moves two inline functions from a header file to the
> corresponding c file.
I think that it is wrong to move inline functions out of a header file.
Many C compilers will not be able to inline it then.
A better solution (IMHO) is to make it "static inline".
Ciao,
Dscho
next prev parent reply other threads:[~2007-05-13 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 21:35 [PATCH] Make git compile with SUNs forte12 compiler Thomas Glanzmann
2007-05-13 9:47 ` Matthieu CASTET
2007-05-13 10:30 ` Thomas Glanzmann
2007-05-13 12:52 ` matthieu castet
2007-05-13 10:39 ` Johannes Schindelin [this message]
2007-05-13 10:52 ` Thomas Glanzmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705131238420.6410@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=sithglan@stud.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).