From: Eric Sunshine <sunshine@sunshineco.com>
To: Simon Ser <contact@emersion.fr>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] grep: add configuration variables for --heading
Date: Tue, 26 May 2020 09:40:29 -0400 [thread overview]
Message-ID: <CAPig+cTkwUyyji19XyTBRvC=RjLNK_OipLJ-+6GTf8PWRfC8WA@mail.gmail.com> (raw)
In-Reply-To: <4WK2xPaKLXPbLE0jjY0rBR9M_BVt69rzJKBN17M0ily4VPYuMNC_a2kXsIKWR8y6lc7j58WpBmaIqdbJ1whnjonrfEWz7YE-WpdQqCu_lN0=@emersion.fr>
On Tue, May 26, 2020 at 4:37 AM Simon Ser <contact@emersion.fr> wrote:
> There are already configuration variables for -n and --column. Add one
> for --heading, allowing users to customize the default behaviour.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> ---
> Documentation/git-grep.txt | 3 +++
> grep.c | 5 +++++
> 2 files changed, 8 insertions(+)
To round this out, adding a test -- probably in t7810-grep.sh -- would
be a good idea.
next prev parent reply other threads:[~2020-05-26 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 8:37 [PATCH] grep: add configuration variables for --heading Simon Ser
2020-05-26 13:40 ` Eric Sunshine [this message]
2020-05-27 15:45 ` [PATCH v2] " Simon Ser
2020-05-27 16:45 ` Junio C Hamano
2020-06-08 10:22 ` Simon Ser
2020-06-08 14:02 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTkwUyyji19XyTBRvC=RjLNK_OipLJ-+6GTf8PWRfC8WA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=contact@emersion.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).