git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Aishwarya Narayanan <aishnana.03@gmail.com>, git@vger.kernel.org
Subject: Re: GSoC 2024 [PATCH v2] Fix Git command exit code suppression in test script t2104-update-index-skip-worktree.sh
Date: Tue, 2 Apr 2024 13:20:53 -0400	[thread overview]
Message-ID: <CAPig+cRtzbv57=k7ti0YcsRR05gz4v_gExgwi6qCtT6f0i2oKA@mail.gmail.com> (raw)
In-Reply-To: <ZgvmoSOPs6FG4jGZ@tanuki>

On Tue, Apr 2, 2024 at 7:06 AM Patrick Steinhardt <ps@pks.im> wrote:
> I assume two things happened:
>
>   - Your patch may have changed line endings. Please make sure that your
>     editor writes Unix-style line endings ("\n"), only.
>
>   - You seem to have changed indentation from four spaces to two spaces.

Micro correction: Documentation/CodingGuidelines says this:

    We use tabs to indent, and interpret tabs as taking up
    to 8 spaces.


  parent reply	other threads:[~2024-04-02 17:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 18:47 GSoC 2024 [PATCH v2] Fix Git command exit code suppression in test script t2104-update-index-skip-worktree.sh Aishwarya Narayanan
2024-04-02 11:06 ` Patrick Steinhardt
2024-04-02 11:56   ` Aishwarya Narayanan
2024-04-02 17:20   ` Eric Sunshine [this message]
2024-04-02 17:23     ` Patrick Steinhardt
2024-04-02 18:41       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cRtzbv57=k7ti0YcsRR05gz4v_gExgwi6qCtT6f0i2oKA@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=aishnana.03@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).