git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Daurnimator <quae@daurnimator.com>
Cc: Cameron Currie <me@cameroncurrie.net>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes
Date: Mon, 2 May 2016 18:21:19 -0700	[thread overview]
Message-ID: <CAPc5daXVBJ=2KJfqcdwyH1Eq54vw-QeOEBF1aGj2dn+Yihcy9A@mail.gmail.com> (raw)
In-Reply-To: <CAEnbY+cu9E8DYGcg8FoK37NGZXbhSKvzVwMpLUEspXRYpPUdaA@mail.gmail.com>

On Mon, May 2, 2016 at 4:56 PM, Daurnimator <quae@daurnimator.com> wrote:
> On 3 May 2016 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:
>
> I agree quiltimport should not, but I think filter-branch possibly
> should... at least for your *own* commits.
> I often think of filter-branch as an "advanced" `git commit --amend`

But it does not do the gpgsign thing only for your own commits right now, and
even if it did, you would not necessarily want it to always use the configured
setting. That means that the command, if it wants to work well with the signed
commits, must learn to honor command line option to enable or disable passing
--gpgsign option to underlying commit-tree *anyway*.

So I think it is a right thing to fix commit-tree to ignore
commit.gpgsign at least
by default.

  reply	other threads:[~2016-05-03  1:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 17:32 [PATCH] git-stash: Don't GPG sign when stashing changes Cameron Currie
2015-11-06 18:56 ` Junio C Hamano
2016-04-07  2:24 ` daurnimator
2016-04-07  8:19   ` Johannes Schindelin
2016-04-12  2:46     ` Daurnimator
     [not found]       ` <CAOAY-+1TztY95z3Yi34HB3aYUG5aOHKK9G3OmpYM41ugDMtJUA@mail.gmail.com>
2016-04-14 15:50         ` Johannes Schindelin
2016-05-02  6:06           ` Daurnimator
2016-05-02 20:50 ` [PATCH v2] " Cameron Currie
2016-05-02 21:57   ` Junio C Hamano
2016-05-02 23:56     ` Daurnimator
2016-05-03  1:21       ` Junio C Hamano [this message]
2016-05-06  6:06         ` Daurnimator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPc5daXVBJ=2KJfqcdwyH1Eq54vw-QeOEBF1aGj2dn+Yihcy9A@mail.gmail.com' \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@cameroncurrie.net \
    --cc=quae@daurnimator.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).