git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: Hariom verma <hariom18599@gmail.com>
Cc: git <git@vger.kernel.org>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
	Thomas Gummerer <t.gummerer@gmail.com>
Subject: Re: [GSoC][RFC][PROPOSAL v3] Unify ref-filter formats with other --pretty formats
Date: Tue, 24 Mar 2020 12:18:46 +0100	[thread overview]
Message-ID: <CAP8UFD2nVnrudUWtNzq4Lc-zyXPU8r9wjvtnBgVTY4vQxsqLzw@mail.gmail.com> (raw)
In-Reply-To: <CA+CkUQ__JPsLCkkdHg7gh8J7VvXLA+v2j3NgV6cZAw94if=9mA@mail.gmail.com>

Hi,

On Sun, Mar 22, 2020 at 3:56 PM Hariom verma <hariom18599@gmail.com> wrote:

> I would love to get my proposal reviewed and have suggestions from you all.

Sorry for the late reviews.

[...]

> My task is to change formatting logic in pretty.c. Actually, to remove
> the current formatting solution and reuse solution from ref-filter
> (maybe without changing pretty.c logically).
> As Thomas<t.gummerer@gmail.com>
> [suggested](https://public-inbox.org/git/20190331184930.GV32487@hank.intra.tgummerer.com/),
> I’ll start by first looking at what actually needed to be replaced
> (for example by studying the PRETTY FORMATS section in 'man git-log',
> what which verbs you can use in the ref-filter ('man
> git-for-each-ref') to achieve the same thing.
> Then I’ll research how one format is implemented in 'pretty.c', and
> see how a similar thing using the ref-filter is implemented in
> 'ref-filter.c'.
> e.g. the "%(objectname:short) %(contents:subject)" (this is missing
> coloring, but just to get you the idea) is similar to
> '--pretty=oneline'.  Now one can try to find how 'oneline' is
> implemented in 'pretty.c', and could translate that to use the
> 'ref-filter' API.
> The idea is to use various atoms present in ref-filter to implement
> pretty format options.

Yeah, I think that's a good idea.

> Valid atoms in ref-filter:
> https://github.com/git/git/blob/master/ref-filter.c#L474-L520

[...]

> ## Blogging about Git
>
> I have always been reluctant to articulate my opinions and broadcast
> them to the world in any way. I have a long way to go as a writer,
> thinker, and as a human being before my opinions on matters of
> personal significance to me will be worth sharing. (Whoa! I have
> opinions about my opinions! Ad infinitum!)
> Having said that, I think GSoC and Git might be a great couple for
> facilitating my first foray into technical blogging. And over the
> course of the summer and beyond, I would love to write about my
> progress and experiences contributing to Git.

Good. If it appears to be too much of a problem, it's ok to just send
weekly email updates to the mailing list.

      reply	other threads:[~2020-03-24 11:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07 19:40 [GSoC][RFC][PROPOSAL v2] Unify ref-filter formats with other --pretty formats Hariom verma
2020-03-22 14:56 ` [GSoC][RFC][PROPOSAL v3] " Hariom verma
2020-03-24 11:18   ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP8UFD2nVnrudUWtNzq4Lc-zyXPU8r9wjvtnBgVTY4vQxsqLzw@mail.gmail.com \
    --to=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hariom18599@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).