From: Christian Couder <christian.couder@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Drew DeVault <sir@cmpwn.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] am: add --check option
Date: Tue, 4 Jun 2019 16:06:07 +0200 [thread overview]
Message-ID: <CAP8UFD0d5ptCpn+u8-p=oa3gZFYdbeW+KapVcmKgqPQKR4scwA@mail.gmail.com> (raw)
In-Reply-To: <c1dec466-55ca-8543-8f4e-b5daf1e0eab6@kdbg.org>
On Tue, Jun 4, 2019 at 8:03 AM Johannes Sixt <j6t@kdbg.org> wrote:
>
> Am 04.06.19 um 00:00 schrieb Drew DeVault:
> > On Mon Jun 3, 2019 at 11:09 PM Johannes Sixt wrote:
> >> I have to wonder how --check works when 'am' applies multiple patches.
> >>
> >> When the second patch in a patch series depends on that the first patch
> >> is fully applied, what does --check do? Without the first patch applied,
> >> then a naive check of the second patch will certainly fail, doesn't it?
> >
> > Yeah, this was being discussed in another thread. It'll fail if the
> > second patch relies on changes from the first. Open to suggestions on
> > how to improve that, but I think it can be improved in a later patch.
I think both features could be useful. For example sometimes a
maintainer might want to know if applying only a patch that is in the
middle of a patch series (for example something security related)
could work without having to apply the previous patchs. So maybe both
a --check and a --dry-run with different behavior regarding patch
series would make sense.
next prev parent reply other threads:[~2019-06-04 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BUKFSM2OTJUH.38N6DGWH9KX7H@homura>
2019-06-04 5:58 ` [PATCH] am: add --check option Johannes Sixt
2019-06-04 13:40 ` Johannes Schindelin
2019-06-04 14:06 ` Christian Couder [this message]
2019-06-03 14:25 Drew DeVault
2019-06-03 15:46 ` SZEDER Gábor
2019-06-03 21:09 ` Johannes Sixt
2019-06-04 15:37 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD0d5ptCpn+u8-p=oa3gZFYdbeW+KapVcmKgqPQKR4scwA@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).