From: Karthik Nayak <karthik.188@gmail.com>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: Jeff King <peff@peff.net>, Git <git@vger.kernel.org>
Subject: Re: [PATCH v2] for-each-ref: add %(upstream:gone) to mark missing refs
Date: Fri, 26 Aug 2016 12:01:29 +0530 [thread overview]
Message-ID: <CAOLa=ZTY0fM_Z_t8nk+je4fao8ydF1dAXmG7RzgmJyoQUj7kSg@mail.gmail.com> (raw)
In-Reply-To: <CAFaJEqs7vE4knXXOdKk+PxY2DZs=7BHGUJY_0a_aKF1ngnX+Lg@mail.gmail.com>
Hello,
>> On Thu, Aug 25, 2016 at 12:03 AM, Jeff King <peff@peff.net> wrote:
>>>
>>> Ah, right. I was feeling like this was all vaguely familiar. I think
>>> it would be better to push forward kn/ref-filter-branch-list.
>>> According to the last "what's cooking", I think that topic is waiting
>>> on more review. If you're willing and able to do so, that would be a
>>> big help.
>>>
>>
>> It's been waiting for review for a _long_ time now.
>>
>
> To be perfectly honest my C skills and familiarity with the git source
> code is not much to speak of. I very much want to take a close look but
> I cannot promise anything worth your time...
>
> But if I do find something I'd like to point out should I just reply
> directly to the e-mails containing the patches as one usually does even
> though they're months old at this point?
>
Not that your review would be absolute but it definitely would be a start.
Replying directly to the patches is the way to go I feel.
--
Regards,
Karthik Nayak
prev parent reply other threads:[~2016-08-26 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 17:35 [PATCH v2] for-each-ref: add %(upstream:gone) to mark missing refs Øystein Walle
2016-08-24 18:07 ` Jeff King
2016-08-24 18:26 ` Øystein Walle
2016-08-24 18:33 ` Jeff King
2016-08-25 5:56 ` Karthik Nayak
2016-08-25 8:45 ` Øystein Walle
2016-08-26 6:31 ` Karthik Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZTY0fM_Z_t8nk+je4fao8ydF1dAXmG7RzgmJyoQUj7kSg@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).