git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* git-svn: ignore-paths not enough (not ignoring refs?)
@ 2011-10-06  8:43 Piotr Krukowiecki
  2011-10-07  0:41 ` Michael Olson
  0 siblings, 1 reply; 2+ messages in thread
From: Piotr Krukowiecki @ 2011-10-06  8:43 UTC (permalink / raw
  To: Michael Olson; +Cc: Eric Wong, Git Mailing List

Hi,

I'm using --ignore-paths options but some paths which should be
ignored (they math the regexp) are not ignored. I suspect this is
because of http://thread.gmane.org/gmane.comp.version-control.git/145398

It seems the patch from that url was never accepted to git. It does
not apply anymore too. Is it possible to update the patch? From the
discussion the patch looked ok (with exception to git-svn dying if a
parent ref didn't exist :) )


Here's my git-svn clone log, with some print lines added to is_path_ignored():

$ git svn clone -s --no-follow-parent  --ignore-paths='$REGEXP -r 1230:1240 $URL
[...]
is_path_ignored: 'xtest/tags/rel1'  # this matches the regexp and
should be ignored
is_path_ignored: 'xtest/tags/rel1/common' # more paths which should be
ignored follow
[...]
r1237 = c660a7e6ad81cafa0a64a7ec85a3e23f0c02bc09
(refs/remotes/tags/rel1) # but it is not!

# I can see the tag:
$ git branch -a
  remotes/tags/rel1

# There are no changes in this change:
$ git show -p c660a7e6ad81cafa0a64a7ec85a3e23f0c02bc09
[...]
    git-svn-id: $URL/rel1@1237 3e523551-a86b-4873-bcb6-76fcd93a4c5c

# Under svn the r1237 is following:
$ svn log -r 1237 -v $URL
------------------------------------------------------------------------
r1237 | ...
Changed paths:
   A /xtest/tags/rel1/common (from /xtest/branches/xtest44/common:1235)

# The xtest/branches/xtest44/common does not match the ignore-paths
and is not ignored.


-- 
Piotr Krukowiecki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: git-svn: ignore-paths not enough (not ignoring refs?)
  2011-10-06  8:43 git-svn: ignore-paths not enough (not ignoring refs?) Piotr Krukowiecki
@ 2011-10-07  0:41 ` Michael Olson
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olson @ 2011-10-07  0:41 UTC (permalink / raw
  To: Piotr Krukowiecki; +Cc: Eric Wong, Git Mailing List

I've resent my patch.  I've been using it with v1.7.4.1.

On Thu, Oct 6, 2011 at 1:43 AM, Piotr Krukowiecki
<piotr.krukowiecki@gmail.com> wrote:
> Hi,
>
> I'm using --ignore-paths options but some paths which should be
> ignored (they math the regexp) are not ignored. I suspect this is
> because of http://thread.gmane.org/gmane.comp.version-control.git/145398
>
> It seems the patch from that url was never accepted to git. It does
> not apply anymore too. Is it possible to update the patch? From the
> discussion the patch looked ok (with exception to git-svn dying if a
> parent ref didn't exist :) )
>
>
> Here's my git-svn clone log, with some print lines added to is_path_ignored():
>
> $ git svn clone -s --no-follow-parent  --ignore-paths='$REGEXP -r 1230:1240 $URL
> [...]
> is_path_ignored: 'xtest/tags/rel1'  # this matches the regexp and
> should be ignored
> is_path_ignored: 'xtest/tags/rel1/common' # more paths which should be
> ignored follow
> [...]
> r1237 = c660a7e6ad81cafa0a64a7ec85a3e23f0c02bc09
> (refs/remotes/tags/rel1) # but it is not!
>
> # I can see the tag:
> $ git branch -a
>  remotes/tags/rel1
>
> # There are no changes in this change:
> $ git show -p c660a7e6ad81cafa0a64a7ec85a3e23f0c02bc09
> [...]
>    git-svn-id: $URL/rel1@1237 3e523551-a86b-4873-bcb6-76fcd93a4c5c
>
> # Under svn the r1237 is following:
> $ svn log -r 1237 -v $URL
> ------------------------------------------------------------------------
> r1237 | ...
> Changed paths:
>   A /xtest/tags/rel1/common (from /xtest/branches/xtest44/common:1235)
>
> # The xtest/branches/xtest44/common does not match the ignore-paths
> and is not ignored.
>
>
> --
> Piotr Krukowiecki
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Michael Olson  |  http://mwolson.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-07  0:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06  8:43 git-svn: ignore-paths not enough (not ignoring refs?) Piotr Krukowiecki
2011-10-07  0:41 ` Michael Olson

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).