From: Alex Henrie <alexhenrie24@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] log: if --decorate is not given, default to --decorate=auto
Date: Thu, 23 Mar 2017 09:07:15 -0600 [thread overview]
Message-ID: <CAMMLpeR-zCpL5Gx=BoK8G9_wL2TBe-wD3VnsAShAuVVzS=Nirg@mail.gmail.com> (raw)
In-Reply-To: <xmqqmvcdmeuv.fsf@gitster.mtv.corp.google.com>
2017-03-22 10:54 GMT-06:00 Junio C Hamano <gitster@pobox.com>:
> Alex Henrie <alexhenrie24@gmail.com> writes:
>> No problem. Do I need to submit a second version of the patch with a
>> test for `git -p log`?
>
> You do want to protect this "without an option, we default to
> 'auto'" feature from future breakage, no?
Yes, but I need to know whether you want a v2 of this patch with all
of the changes including the new test, or a second patch that depends
on the first patch and only adds the new test.
-Alex
next prev parent reply other threads:[~2017-03-23 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 5:52 [PATCH] log: if --decorate is not given, default to --decorate=auto Alex Henrie
2017-03-21 17:34 ` Junio C Hamano
2017-03-21 22:28 ` Junio C Hamano
2017-03-22 5:47 ` Alex Henrie
2017-03-22 16:54 ` Junio C Hamano
2017-03-23 15:07 ` Alex Henrie [this message]
2017-03-23 15:54 ` Junio C Hamano
2017-03-23 16:52 ` Alex Henrie
2017-03-23 18:03 ` Junio C Hamano
2017-03-24 5:45 ` Alex Henrie
2017-03-24 18:55 ` Jeff King
2017-03-24 18:59 ` [PATCH] pager_in_use: use git_env_bool() Jeff King
2017-03-24 19:13 ` [PATCH] log: if --decorate is not given, default to --decorate=auto Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMMLpeR-zCpL5Gx=BoK8G9_wL2TBe-wD3VnsAShAuVVzS=Nirg@mail.gmail.com' \
--to=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).