git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Birger Skogeng Pedersen <birger.sp@gmail.com>,
	Philip Oakley <philipoakley@iee.email>
Subject: Re: [PATCH] git-gui: convert new/amend commit radiobutton to checketton
Date: Fri, 13 Sep 2019 22:19:45 +0200	[thread overview]
Message-ID: <CAKPyHN0pSpX6-5TTNZWNshMKa2Bfj3_tujn=HbLNSzBmeRfrYw@mail.gmail.com> (raw)
In-Reply-To: <20190913194911.3vwki4wa4jd3capr@yadavpratyush.com>

On Fri, Sep 13, 2019 at 9:49 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
>
> You missed fixing the typo in the subject. s/checketton/checkbutton/.
> But no need to send a re-roll for that. I can fix it locally.

thanks, I also fixed that locally, but again, it slipped thru in the
patch mail. Still don't know why this happened.

Best,
Bert

>
> Other than that, LGTM. Thanks, will queue.
>
> On 13/09/19 08:02AM, Bert Wesarg wrote:
> > Its a bi-state anyway and also saves one line in the menu.
> >
> > Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>
> --
> Regards,
> Pratyush Yadav

      reply	other threads:[~2019-09-13 20:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 19:44 [PATCH] git-gui: convert new/amend commit radiobutton to checketton Bert Wesarg
2019-09-12 22:15 ` Philip Oakley
2019-09-13  6:02   ` Bert Wesarg
2019-09-13 19:49     ` Pratyush Yadav
2019-09-13 20:19       ` Bert Wesarg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKPyHN0pSpX6-5TTNZWNshMKa2Bfj3_tujn=HbLNSzBmeRfrYw@mail.gmail.com' \
    --to=bert.wesarg@googlemail.com \
    --cc=birger.sp@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    --cc=philipoakley@iee.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).