From: "Jorge A López Silva" <jalopezsilva@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Jorge Lopez Silva via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] http: add client cert for HTTPS proxies.
Date: Wed, 26 Feb 2020 13:05:00 -0800 [thread overview]
Message-ID: <CAJyLMU9yKZQ673PTopxVcyx-OAk2kVSAt8nYLYYQw9-GFF00ZQ@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cRYCC9MvAgVecEuvK1wqvWpVWS0ipmKPMKSctFbjHThvQ@mail.gmail.com>
Thanks Eric for the feedback. I'm addressing your comments and sending a v2.
On Fri, Feb 21, 2020 at 2:28 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Fri, Feb 21, 2020 at 4:37 PM Jorge Lopez Silva via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > Git currently supports performing connections to HTTPS proxies but we
> > don't support doing mutual authentication with them (through TLS). This
> > commit adds the necessary options to be able to send a client
> > certificate to the HTTPS proxy.
> > [...]
> > Signed-off-by: Jorge Lopez Silva <jalopezsilva@gmail.com>
> > ---
> > diff --git a/http.c b/http.c
> > @@ -1018,9 +1046,23 @@ static CURL *get_curl_handle(void)
> > #if LIBCURL_VERSION_NUM >= 0x073400
> > - else if (starts_with(curl_http_proxy, "https"))
> > + else if (starts_with(curl_http_proxy, "https")) {
> > curl_easy_setopt(result,
> > CURLOPT_PROXYTYPE, CURLPROXY_HTTPS);
> > +
> > + if (http_proxy_ssl_cert != NULL) {
> > + curl_easy_setopt(result,
> > + CURLOPT_PROXY_SSLCERT, http_proxy_ssl_cert);
> > + }
> > + if (http_proxy_ssl_key != NULL) {
> > + curl_easy_setopt(result,
> > + CURLOPT_PROXY_SSLKEY, http_proxy_ssl_key);
> > + }
> > + if (http_proxy_ssl_key_passwd != NULL) {
> > + curl_easy_setopt(result,
> > + CURLOPT_PROXY_KEYPASSWD, http_proxy_ssl_key_passwd);
> > + }
> > + }
> > #endif
>
> All the closing braces in this hunk seem to be over-indented. Also,
> all of the braces for the one-liner 'if' bodies can be dropped, thus
> making it less noisy.
next prev parent reply other threads:[~2020-02-26 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:36 [PATCH 0/2] Add HTTPS proxy SSL options (cert, key, cainfo) Jorge via GitGitGadget
2020-02-21 21:36 ` [PATCH 1/2] http: add client cert for HTTPS proxies Jorge Lopez Silva via GitGitGadget
2020-02-21 22:28 ` Eric Sunshine
2020-02-26 21:05 ` Jorge A López Silva [this message]
2020-02-21 21:36 ` [PATCH 2/2] config: documentation for HTTPS proxy client cert Jorge Lopez Silva via GitGitGadget
2020-02-26 23:23 ` [PATCH v2 0/2] Add HTTPS proxy SSL options (cert, key, cainfo) Jorge via GitGitGadget
2020-02-26 23:23 ` [PATCH v2 1/2] http: add client cert for HTTPS proxies Jorge Lopez Silva via GitGitGadget
2020-02-27 18:31 ` Junio C Hamano
2020-03-03 1:41 ` Jorge A López Silva
2020-02-26 23:23 ` [PATCH v2 2/2] config: documentation for HTTPS proxy client cert Jorge Lopez Silva via GitGitGadget
2020-02-27 18:58 ` Junio C Hamano
2020-03-03 1:47 ` Jorge A López Silva
2020-03-04 18:40 ` [PATCH v3 0/2] Add HTTPS proxy SSL options (cert, key, cainfo) Jorge via GitGitGadget
2020-03-04 18:40 ` [PATCH v3 1/2] http: add client cert for HTTPS proxies Jorge Lopez Silva via GitGitGadget
2020-03-04 18:40 ` [PATCH v3 2/2] http: add environment variable for HTTPS proxy Jorge Lopez Silva via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJyLMU9yKZQ673PTopxVcyx-OAk2kVSAt8nYLYYQw9-GFF00ZQ@mail.gmail.com \
--to=jalopezsilva@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).