git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kenneth Cochran <kenneth.cochran101@gmail.com>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: git@vger.kernel.org, Sahil Dua <sahildua2305@gmail.com>,
	Duy Nguyen <pclouds@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [RFC PATCH 4/4] Add alias option to git branch
Date: Mon, 4 Mar 2019 13:52:10 -0600	[thread overview]
Message-ID: <CAJ145vUOYcMvozYtWx2QJOWCSGw__-Cs3w_sxKhwwtHFQt-qHA@mail.gmail.com> (raw)
In-Reply-To: <95defc95-c558-3487-d418-e65f7db5dda5@orcon.net.nz>

On Mon, Mar 4, 2019 at 1:34 PM Phil Sainty <psainty@orcon.net.nz> wrote:
>
> 5/03/19 5:23 AM, Kenneth Cochran wrote:
> > Adding Phil for comments
>
> Thank you for following this up, Kenneth.  I'll do some testing with
> your patch sometime soon.

Thanks! Any feedback is appreciated.

>
> I've realised that the last version of my script that I posted to the
> mailing list was buggy, and that in wanting to hold off sending another
> version for a little while in case I found more bugs, I in fact failed
> to send a fixed version at all.
>
> This is probably not relevant to your patches; but just in case,
> the up to date code for that script is here:
>
> https://stackoverflow.com/a/23532744/324105

This stack overflow post was actually what led me to the git mailing
list in the first place :)

>
> and the fixes since v1.11 were:
>
> * Change incorrect uses of git show-ref, introduced by v1.10 (including
>   effective regression of v1.08), to use git symbolic-ref instead.
>
> * Fix the option handling for '--', and added it to the help text.
>
>
> -Phil

On Mon, Mar 4, 2019 at 1:34 PM Phil Sainty <psainty@orcon.net.nz> wrote:
>
> 5/03/19 5:23 AM, Kenneth Cochran wrote:
> > Adding Phil for comments
>
> Thank you for following this up, Kenneth.  I'll do some testing with
> your patch sometime soon.
>
> I've realised that the last version of my script that I posted to the
> mailing list was buggy, and that in wanting to hold off sending another
> version for a little while in case I found more bugs, I in fact failed
> to send a fixed version at all.
>
> This is probably not relevant to your patches; but just in case,
> the up to date code for that script is here:
>
> https://stackoverflow.com/a/23532744/324105
>
> and the fixes since v1.11 were:
>
> * Change incorrect uses of git show-ref, introduced by v1.10 (including
>   effective regression of v1.08), to use git symbolic-ref instead.
>
> * Fix the option handling for '--', and added it to the help text.
>
>
> -Phil

  reply	other threads:[~2019-03-04 19:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 15:45 [RFC PATCH 0/4] Add alias option to git branch Kenneth Cochran
2019-03-04 15:47 ` [RFC PATCH 1/4] " Kenneth Cochran
2019-03-04 15:48   ` [RFC PATCH 2/4] " Kenneth Cochran
2019-03-04 15:49     ` [RFC PATCH 3/4] " Kenneth Cochran
2019-03-04 15:49       ` [RFC PATCH 4/4] " Kenneth Cochran
2019-03-04 16:38         ` Kenneth Cochran
     [not found]         ` <CAJ145vUChd7+5QkmJsOK3bzZsudWfzZYp5wHZDzoq8SKSv0g0A@mail.gmail.com>
2019-03-04 19:33           ` Phil Sainty
2019-03-04 19:52             ` Kenneth Cochran [this message]
2019-03-05 13:21 ` [RFC PATCH 0/4] " Junio C Hamano
2019-03-05 17:36   ` Kenneth Cochran
2019-03-06 10:13     ` Phil Sainty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ145vUOYcMvozYtWx2QJOWCSGw__-Cs3w_sxKhwwtHFQt-qHA@mail.gmail.com \
    --to=kenneth.cochran101@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=psainty@orcon.net.nz \
    --cc=sahildua2305@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).