From: Sangeeta NB <sangunb09@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Taylor Blau <me@ttaylorr.com>,
phillip.wood@dunelm.org.uk,
Sangeeta via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH][OUTREACHY] bisect: allow `git bisect` to run from subdirectory
Date: Fri, 23 Oct 2020 16:29:52 +0530 [thread overview]
Message-ID: <CAHjREB7+3QtPw6X33GEB8SiDjSfvNhb15+_rpy=McmqBdcMebQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq7drinqxv.fsf@gitster.c.googlers.com>
Hey everyone,
Sorry for participating in the discussions so late. I thought I need
to have enough knowledge first before participating.
>
> If a step in the rebase sequence makes a directory disappear (or
> turns a directory into a file), and the command given by -x is in
> the directory (it is immaterial if it is given as relative or full
> pathname from the command line), hopefully the step of the rebase
> sequence that would lose the directory would error out, in order to
> prevent an untracked but not ignored file from getting clobbered.
>
> Even before speculating such an "advanced" mode of operation, do we
> know that rebasing a history that makes a directory disappear and
> reappear work?
>
Yes, I agree. We need to make some changes in `git rebase` to make it
work from the subdirectory, but that doesn't mean that we should
completely restrict it from running in the subdirectory, and the same
follows for `git bisect`.
What I think that we should allow `git bisect` from any subdirectory.
We can add some warnings in case if there's some error while bisecting
from a subdirectory in the same way by which we handle the errors in
`git rebase` and let the user decide whether he still wants to
continue bisecting from that subdirectory or abort it and run it from
the top-level directory.
next prev parent reply other threads:[~2020-10-23 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 9:09 [PATCH] bisect: allow `git bisect` to run from subdirectory Sangeeta via GitGitGadget
2020-10-21 13:41 ` [PATCH][OUTREACHY] " Phillip Wood
2020-10-21 16:20 ` Taylor Blau
2020-10-21 19:53 ` Junio C Hamano
2020-10-22 8:52 ` Johannes Schindelin
2020-10-22 9:46 ` Phillip Wood
2020-10-22 16:52 ` Junio C Hamano
2020-10-23 10:59 ` Sangeeta NB [this message]
2020-10-23 15:43 ` Junio C Hamano
2020-10-23 15:18 ` Phillip Wood
2020-10-22 8:47 ` Johannes Schindelin
2020-10-22 9:52 ` Phillip Wood
2020-10-22 17:04 ` Junio C Hamano
2020-10-23 8:37 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHjREB7+3QtPw6X33GEB8SiDjSfvNhb15+_rpy=McmqBdcMebQ@mail.gmail.com' \
--to=sangunb09@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).