From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 9196C1F619 for ; Wed, 11 Mar 2020 19:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731093AbgCKT3f (ORCPT ); Wed, 11 Mar 2020 15:29:35 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:38590 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730913AbgCKT3f (ORCPT ); Wed, 11 Mar 2020 15:29:35 -0400 Received: by mail-lf1-f65.google.com with SMTP id n13so925793lfh.5 for ; Wed, 11 Mar 2020 12:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SPaAaVEfXdmjo6am9fFBhDN9JLLSg3ImblcuUQW8vjY=; b=hMdUn1wmMwwJ2FydXFvHjrywUpunAubPdOwMvaPveuzhrdHjIomjfYsgbhxX1G3C4v vuBZh4GCEZ2GaAgPNBT8+/uujOrYF7EyBgXy0cWL96JuYLrHoyFROtoP4A2Ob4IM/bRc nTvkBShHu2ghH492qHUQjoDRB6EigEcdswvPoN8qeGw12jtYzVWL48V/LZAVya/cmnFn 9HLRNWTZbPjA9sTjhqGvLmDeb+W0QBArPXMgrO+nPVZB08m+QdAFHm8OKIZ49krD6ruQ p66ned0p97Q84ppSjnKtAghwF8Hc21tvxxF7A9+Fj5YPglcbH3MUM2UrAEVDdPy5xOZZ 8Gww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SPaAaVEfXdmjo6am9fFBhDN9JLLSg3ImblcuUQW8vjY=; b=iFCqcwIQqk7c6z4FXhlgrjqoQ0YZQqKw0Gr+b0F9ldD0tOJlNnzBNmhtP93/hgH6/Y cAw/YhBhqKDddKxmZp7Vyl3FVmTefUOiBPKt9IF0N3gB5VLsq7Csf0CTNjbkLZdbignx cRiuBlEFcDLQHqjArxQYEAwdC/zLVOzUaL0bwXEjnSkTEbN7EPXgnDi7vLZwvM0Shgg4 Uk4t6Wm9ZK93JOLYcJxuPqUP2vi88rmlLuSSsV3km1iUXay3eOhZ7ihC1zOCuLXO1mNO 2M8a20otAQHgJDAcSJMqb7BOt6FzLZbcQMTCEx2mRiN2spkYxGtY8aEWQX4SQ4t8BMNk W6PQ== X-Gm-Message-State: ANhLgQ1hXSDqe8mkeaL4tAKPcr9159bAOu6JYC3AiX0JHmfUPqfSS+mU 3naCTkuitWBhgWgItmE5Fv0HNHy3y9aFvYxv7w1PvA1PXqY= X-Google-Smtp-Source: ADFU+vsJb10Dn2HBiAfi/DRaUnQmaSzDgCGpKGNllLZ/97quBPy6gykKU0ToiYmyqWi4wMKmFFRhQyLg27hJAFJAPZw= X-Received: by 2002:a05:6512:31d5:: with SMTP id j21mr3037483lfe.23.1583954973282; Wed, 11 Mar 2020 12:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20200311180625.4643-1-shubhunic@gmail.com> In-Reply-To: <20200311180625.4643-1-shubhunic@gmail.com> From: Matheus Tavares Bernardino Date: Wed, 11 Mar 2020 16:29:22 -0300 Message-ID: Subject: Re: [GSOC] [PATCH] replace test -f with test_path_is_file To: Shubham Verma Cc: git Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi, Shubham. Welcome to the community! On Wed, Mar 11, 2020 at 3:06 PM Shubham Verma wrote: > > Subject: [GSOC] [PATCH] replace test -f with test_path_is_file It's common to prefix the patch title with "area: ", where "area" corresponds to the codebase section which the patch is modifying. This makes it easier to understand the scope of the change. You can check what others have been using for this specific file with `git log --no-merges t/t9801-git-p4-branch.sh`. In this case, I think a better alternative would be: "t9801: replace test -f with test_path_is_file" > Although `test -f` has the same functionality as test_path_is_file(), in the case where test_path_is_file() fails, we get much better > debugging information. > > Replace `test -f` with test_path_is_file() so that future developers will have a better experience debugging these test cases. It's also a good practice to wrap the commit body in 72 columns. This will, for example, help viewing the message in most terminals. And, please, add your Signed-off-by[1] in the footer of the message. [1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L299 > --- > t/t9801-git-p4-branch.sh | 38 +++++++++++++++++++------------------- > 1 file changed, 19 insertions(+), 19 deletions(-) As for the changes, LGTM :)