git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bryan Turner <bturner@atlassian.com>
To: Git Users <git@vger.kernel.org>
Subject: Split commit graphs and commit-graph read
Date: Fri, 8 Nov 2019 15:41:36 -0800	[thread overview]
Message-ID: <CAGyf7-G3NDp--2nUbri_0EqvSLF21M0gsFCOKDCWMY+e68Htog@mail.gmail.com> (raw)

Just a quick question about a behavior I've noticed with the commit
graph. (Amazing feature, by the way!)

If the _very first_ write done is split:
git commit-graph write --reachable --split

You end up with something like this:
.../objects$ ls -R info
info:
commit-graphs  packs

info/commit-graphs:
commit-graph-chain  graph-6612fcc8fd04d3af2cc268a6bd9161ae40f5fcbf.graph

info/commit-graph doesn't exist, but I have a 1-graph "chain" in
place. (And subsequent write --split calls write additional ones; I've
got a few now in this repository, but still no info/commit-graph.)

git commit-graph verify seems happy:
.../objects$ git commit-graph verify
Verifying commits in commit graph: 100% (98768/98768), done.

But git commit-graph read isn't:
.../objects$ git commit-graph read
fatal: Could not open commit-graph
'/path/to/repository/objects/info/commit-graph': No such file or
directory

Running some tests with commands like git for-each-ref and git
rev-list shows that the "split" commit graph is being used (setting
core.commitGraph=false makes commands noticeably slower), so
functionally all seems well. But should git commit-graph read be
handling this better?

Best regards,
Bryan Turner

             reply	other threads:[~2019-11-08 23:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 23:41 Bryan Turner [this message]
2019-11-11  1:19 ` Split commit graphs and commit-graph read Derrick Stolee
2019-11-11  2:09   ` Junio C Hamano
2019-11-11  3:29   ` Jeff King
2019-11-12  0:28   ` Bryan Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGyf7-G3NDp--2nUbri_0EqvSLF21M0gsFCOKDCWMY+e68Htog@mail.gmail.com \
    --to=bturner@atlassian.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).