Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

[Birger Skogeng Pedersen <birger.sp@gmail.com>]

Hi Bert,


We should probably distinguish between what is wrapped in git-gui
(i.e. purely visual), and what is actually wrapped in the commit
message.
I believe the former is referred to as "soft wrap", while the latter
is "hard wrap".


On Thu, Sep 5, 2019 at 7:46 PM Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> Please exclude the first line, i.e., the subject. This should not be
> wrapped at all.

I think all lines should be soft wrapped. Scrolling sideways is just
not something I'd want to do in the gui.

How about we soft wrap all lines (in gui). But when the commit is
created, the actual hard wrap (newline characters) happens only on
lines other than the first one?

But then again, the user might get frustrated when the resulting
commit message looks different than what it appeared in git-gui.

Honestly I'd prefer just wrap the first line as well. If the user gets
frustrated that the first line gets wrapped there are two options:
- Refrain from writing such a long line
- Disable word wrapping (it should be configurable, like you said)

Thoughts?



Birger