git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-02 19:49 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
@ 2019-09-02 19:56 ` Birger Skogeng Pedersen
  2019-09-03  8:52   ` Bert Wesarg
  0 siblings, 1 reply; 9+ messages in thread
From: Birger Skogeng Pedersen @ 2019-09-02 19:56 UTC (permalink / raw)
  To: git; +Cc: Birger Skogeng Pedersen

Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.

With this patch, the user may toggle between the two options with
CTRL/CMD+e.

Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
---
 git-gui.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8..14be1e0 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2640,6 +2640,16 @@ proc show_less_context {} {
 	}
 }
 
+proc toggle_commit_type {} {
+	global selected_commit_type
+	if {[string match amend* $selected_commit_type]} {
+		set selected_commit_type new
+	} else {
+		set selected_commit_type amend
+	}
+	do_select_commit_type
+}
+
 ######################################################################
 ##
 ## ui construction
@@ -3843,6 +3853,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
 bind .   <$M1B-Key-plus> {show_more_context;break}
 bind .   <$M1B-Key-KP_Add> {show_more_context;break}
 bind .   <$M1B-Key-Return> do_commit
+bind .   <$M1B-Key-e> toggle_commit_type
 foreach i [list $ui_index $ui_workdir] {
 	bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
 	bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-02 19:56 ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
@ 2019-09-03  8:52   ` Bert Wesarg
  2019-09-03 10:25     ` Bert Wesarg
  2019-09-03 16:20     ` Bert Wesarg
  0 siblings, 2 replies; 9+ messages in thread
From: Bert Wesarg @ 2019-09-03  8:52 UTC (permalink / raw)
  To: Birger Skogeng Pedersen; +Cc: Git Mailing List, David Aguilar, David

Birger,

On Mon, Sep 2, 2019 at 9:56 PM Birger Skogeng Pedersen
<birger.sp@gmail.com> wrote:
>
> Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> a hotkey.
>
> With this patch, the user may toggle between the two options with
> CTRL/CMD+e.

David A. (in Cc from git-cola) suggested, that we try to re-use
existing key bindings in Git GUIs. Here is Git-Cola hotkeys:

http://git-cola.github.io/share/doc/git-cola/hotkeys.html

and this indicates, that it already uses CTRL+m for "amend". Though
I'm unsure if this is a toggle like in git-gui or a one-shot. David
A., can you please clarify?

>
> Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
> ---
>  git-gui.sh | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 5bc21b8..14be1e0 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -2640,6 +2640,16 @@ proc show_less_context {} {
>         }
>  }
>
> +proc toggle_commit_type {} {
> +       global selected_commit_type
> +       if {[string match amend* $selected_commit_type]} {
> +               set selected_commit_type new
> +       } else {
> +               set selected_commit_type amend
> +       }
> +       do_select_commit_type
> +}
> +
>  ######################################################################
>  ##
>  ## ui construction
> @@ -3843,6 +3853,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
>  bind .   <$M1B-Key-plus> {show_more_context;break}
>  bind .   <$M1B-Key-KP_Add> {show_more_context;break}
>  bind .   <$M1B-Key-Return> do_commit
> +bind .   <$M1B-Key-e> toggle_commit_type

The commit type has also a two toggle menu entries (under "Commit")
they should now also indicate the key binding.
disable

Though how to express a toggle keybinding in the menu? I don't know if
you can assign the same keybinding to the same menu entry. Maybe we
need to add/remove the keybinding depending on the current mode.

Bert

>  foreach i [list $ui_index $ui_workdir] {
>         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
>         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }
> --
> 2.21.0.windows.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-03  8:52   ` Bert Wesarg
@ 2019-09-03 10:25     ` Bert Wesarg
  2019-09-03 16:20     ` Bert Wesarg
  1 sibling, 0 replies; 9+ messages in thread
From: Bert Wesarg @ 2019-09-03 10:25 UTC (permalink / raw)
  To: David Aguilar; +Cc: Git Mailing List, Birger Skogeng Pedersen, David

David,

On Tue, Sep 3, 2019 at 10:52 AM Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>
> Birger,
>
> On Mon, Sep 2, 2019 at 9:56 PM Birger Skogeng Pedersen
> <birger.sp@gmail.com> wrote:
> >
> > Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> > a hotkey.
> >
> > With this patch, the user may toggle between the two options with
> > CTRL/CMD+e.
>
> David A. (in Cc from git-cola) suggested, that we try to re-use
> existing key bindings in Git GUIs. Here is Git-Cola hotkeys:
>
> http://git-cola.github.io/share/doc/git-cola/hotkeys.html
>
> and this indicates, that it already uses CTRL+m for "amend". Though
> I'm unsure if this is a toggle like in git-gui or a one-shot. David
> A., can you please clarify?

git-gui already assigns CTRL+m to "Local merge…"

sorry. I think trying to synchronize the keybindings seems impossible.

Bert

>
> >
> > Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
> > ---
> >  git-gui.sh | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/git-gui.sh b/git-gui.sh
> > index 5bc21b8..14be1e0 100755
> > --- a/git-gui.sh
> > +++ b/git-gui.sh
> > @@ -2640,6 +2640,16 @@ proc show_less_context {} {
> >         }
> >  }
> >
> > +proc toggle_commit_type {} {
> > +       global selected_commit_type
> > +       if {[string match amend* $selected_commit_type]} {
> > +               set selected_commit_type new
> > +       } else {
> > +               set selected_commit_type amend
> > +       }
> > +       do_select_commit_type
> > +}
> > +
> >  ######################################################################
> >  ##
> >  ## ui construction
> > @@ -3843,6 +3853,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
> >  bind .   <$M1B-Key-plus> {show_more_context;break}
> >  bind .   <$M1B-Key-KP_Add> {show_more_context;break}
> >  bind .   <$M1B-Key-Return> do_commit
> > +bind .   <$M1B-Key-e> toggle_commit_type
>
> The commit type has also a two toggle menu entries (under "Commit")
> they should now also indicate the key binding.
> disable
>
> Though how to express a toggle keybinding in the menu? I don't know if
> you can assign the same keybinding to the same menu entry. Maybe we
> need to add/remove the keybinding depending on the current mode.
>
> Bert
>
> >  foreach i [list $ui_index $ui_workdir] {
> >         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
> >         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }
> > --
> > 2.21.0.windows.1
> >

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-03  8:52   ` Bert Wesarg
  2019-09-03 10:25     ` Bert Wesarg
@ 2019-09-03 16:20     ` Bert Wesarg
  1 sibling, 0 replies; 9+ messages in thread
From: Bert Wesarg @ 2019-09-03 16:20 UTC (permalink / raw)
  To: Birger Skogeng Pedersen; +Cc: Git Mailing List, David Aguilar, David

Birger,

On Tue, Sep 3, 2019 at 10:52 AM Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>
> Birger,
>
> On Mon, Sep 2, 2019 at 9:56 PM Birger Skogeng Pedersen
> <birger.sp@gmail.com> wrote:
> >
> > Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> > a hotkey.
> >
> > With this patch, the user may toggle between the two options with
> > CTRL/CMD+e.
>
> David A. (in Cc from git-cola) suggested, that we try to re-use
> existing key bindings in Git GUIs. Here is Git-Cola hotkeys:
>
> http://git-cola.github.io/share/doc/git-cola/hotkeys.html
>
> and this indicates, that it already uses CTRL+m for "amend". Though
> I'm unsure if this is a toggle like in git-gui or a one-shot. David
> A., can you please clarify?
>
> >
> > Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
> > ---
> >  git-gui.sh | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/git-gui.sh b/git-gui.sh
> > index 5bc21b8..14be1e0 100755
> > --- a/git-gui.sh
> > +++ b/git-gui.sh
> > @@ -2640,6 +2640,16 @@ proc show_less_context {} {
> >         }
> >  }
> >
> > +proc toggle_commit_type {} {
> > +       global selected_commit_type
> > +       if {[string match amend* $selected_commit_type]} {
> > +               set selected_commit_type new
> > +       } else {
> > +               set selected_commit_type amend
> > +       }
> > +       do_select_commit_type
> > +}
> > +
> >  ######################################################################
> >  ##
> >  ## ui construction
> > @@ -3843,6 +3853,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
> >  bind .   <$M1B-Key-plus> {show_more_context;break}
> >  bind .   <$M1B-Key-KP_Add> {show_more_context;break}
> >  bind .   <$M1B-Key-Return> do_commit
> > +bind .   <$M1B-Key-e> toggle_commit_type
>
> The commit type has also a two toggle menu entries (under "Commit")
> they should now also indicate the key binding.
> disable
>
> Though how to express a toggle keybinding in the menu? I don't know if
> you can assign the same keybinding to the same menu entry. Maybe we
> need to add/remove the keybinding depending on the current mode.

that works. I squashed this into your commit and pushed to GitHub
(sorry, still no path-per-mail)

https://github.com/bertwesarg/git-gui/commit/245bb9944e3d1c6b266c58b56d316f283ed3516b

Bert

>
> Bert
>
> >  foreach i [list $ui_index $ui_workdir] {
> >         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
> >         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }
> > --
> > 2.21.0.windows.1
> >

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
@ 2019-09-04  5:58 Birger Skogeng Pedersen
  2019-09-04 17:36 ` Pratyush Yadav
  0 siblings, 1 reply; 9+ messages in thread
From: Birger Skogeng Pedersen @ 2019-09-04  5:58 UTC (permalink / raw)
  To: Pratyush Yadav; +Cc: git, Bert Wesarg

Hi Pratyush,


So how does this work? Should I email the patch that Bert has created?
Or is it okay that it just remains on Github. (Considering the git
mail archives)


Birger

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-04  5:58 [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
@ 2019-09-04 17:36 ` Pratyush Yadav
  2019-09-04 17:59   ` [PATCH v2] git-gui: add " Birger Skogeng Pedersen
  2019-09-04 18:55   ` [PATCH] Add " Bert Wesarg
  0 siblings, 2 replies; 9+ messages in thread
From: Pratyush Yadav @ 2019-09-04 17:36 UTC (permalink / raw)
  To: Birger Skogeng Pedersen; +Cc: git, Bert Wesarg

On 04/09/19 07:58AM, Birger Skogeng Pedersen wrote:
> Hi Pratyush,
> 
> 
> So how does this work? Should I email the patch that Bert has created?
> Or is it okay that it just remains on Github. (Considering the git
> mail archives)

I think it would be a good idea to send it on the list once before we go 
ahead with it.  This way other people who are interested can take a 
look.  They might not necessarily pay enough attention to the threads to 
notice the GitHub link.  And there is, as you mentioned, the added 
benefit of having it on the mailing list archives.

-- 
Regards,
Pratyush Yadav

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] git-gui: add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-04 17:36 ` Pratyush Yadav
@ 2019-09-04 17:59   ` Birger Skogeng Pedersen
  2019-09-05 20:14     ` Bert Wesarg
  2019-09-04 18:55   ` [PATCH] Add " Bert Wesarg
  1 sibling, 1 reply; 9+ messages in thread
From: Birger Skogeng Pedersen @ 2019-09-04 17:59 UTC (permalink / raw)
  To: git; +Cc: me, Birger Skogeng Pedersen, Bert Wesarg

Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.

With this patch, the user may toggle between the two options with
CTRL/CMD+e.

Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
---
 git-gui.sh | 40 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 35 insertions(+), 5 deletions(-)

diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8..47c5db0 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1445,7 +1445,7 @@ proc force_amend {} {
 	set commit_type $newType
 
 	set selected_commit_type amend
-	do_select_commit_type
+	ui_select_commit_type
 }
 
 proc rescan {after {honor_trustmtime 1}} {
@@ -2640,6 +2640,16 @@ proc show_less_context {} {
 	}
 }
 
+proc toggle_commit_type {} {
+	global selected_commit_type
+	if {[string match amend* $selected_commit_type]} {
+		set selected_commit_type new
+	} else {
+		set selected_commit_type amend
+	}
+	ui_select_commit_type
+}
+
 ######################################################################
 ##
 ## ui construction
@@ -2824,13 +2834,31 @@ proc commit_btn_caption {} {
 	}
 }
 
+proc ui_select_commit_type {} {
+	global selected_commit_type
+	global ui_commit_type_commit ui_commit_type_amend
+
+	do_select_commit_type
+	if {$selected_commit_type eq {new}} {
+		.mbar.commit entryconf [mc "New Commit"] \
+			-accelerator {}
+		.mbar.commit entryconf [mc "Amend Last Commit"] \
+			-accelerator $::M1T-E
+	} elseif {$selected_commit_type eq {amend}} {
+		.mbar.commit entryconf [mc "New Commit"] \
+			-accelerator $::M1T-E
+		.mbar.commit entryconf [mc "Amend Last Commit"] \
+			-accelerator {}
+	}
+}
+
 if {[is_enabled multicommit] || [is_enabled singlecommit]} {
 	menu .mbar.commit
 
 	if {![is_enabled nocommit]} {
 		.mbar.commit add radiobutton \
 			-label [mc "New Commit"] \
-			-command do_select_commit_type \
+			-command ui_select_commit_type \
 			-variable selected_commit_type \
 			-value new
 		lappend disable_on_lock \
@@ -2838,7 +2866,8 @@ if {[is_enabled multicommit] || [is_enabled singlecommit]} {
 
 		.mbar.commit add radiobutton \
 			-label [mc "Amend Last Commit"] \
-			-command do_select_commit_type \
+			-accelerator $M1T-E \
+			-command ui_select_commit_type \
 			-variable selected_commit_type \
 			-value amend
 		lappend disable_on_lock \
@@ -3315,14 +3344,14 @@ set ui_coml .vpane.lower.commarea.buffer.header.l
 if {![is_enabled nocommit]} {
 	${NS}::radiobutton .vpane.lower.commarea.buffer.header.new \
 		-text [mc "New Commit"] \
-		-command do_select_commit_type \
+		-command ui_select_commit_type \
 		-variable selected_commit_type \
 		-value new
 	lappend disable_on_lock \
 		[list .vpane.lower.commarea.buffer.header.new conf -state]
 	${NS}::radiobutton .vpane.lower.commarea.buffer.header.amend \
 		-text [mc "Amend Last Commit"] \
-		-command do_select_commit_type \
+		-command ui_select_commit_type \
 		-variable selected_commit_type \
 		-value amend
 	lappend disable_on_lock \
@@ -3843,6 +3872,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
 bind .   <$M1B-Key-plus> {show_more_context;break}
 bind .   <$M1B-Key-KP_Add> {show_more_context;break}
 bind .   <$M1B-Key-Return> do_commit
+bind .   <$M1B-Key-e> toggle_commit_type
 foreach i [list $ui_index $ui_workdir] {
 	bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
 	bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-04 17:36 ` Pratyush Yadav
  2019-09-04 17:59   ` [PATCH v2] git-gui: add " Birger Skogeng Pedersen
@ 2019-09-04 18:55   ` Bert Wesarg
  1 sibling, 0 replies; 9+ messages in thread
From: Bert Wesarg @ 2019-09-04 18:55 UTC (permalink / raw)
  To: Pratyush Yadav; +Cc: Birger Skogeng Pedersen, Git Mailing List

On Wed, Sep 4, 2019 at 7:36 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
>
> On 04/09/19 07:58AM, Birger Skogeng Pedersen wrote:
> > Hi Pratyush,
> >
> >
> > So how does this work? Should I email the patch that Bert has created?
> > Or is it okay that it just remains on Github. (Considering the git
> > mail archives)
>
> I think it would be a good idea to send it on the list once before we go
> ahead with it.  This way other people who are interested can take a
> look.  They might not necessarily pay enough attention to the threads to
> notice the GitHub link.  And there is, as you mentioned, the added
> benefit of having it on the mailing list archives.

I'm finally able to send patches around again. Though I find the idea
from Johannes appealing to convert this to a check button. Are you
with this?

Bert

>
> --
> Regards,
> Pratyush Yadav

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] git-gui: add hotkey to toggle "Amend Last Commit" radio selector
  2019-09-04 17:59   ` [PATCH v2] git-gui: add " Birger Skogeng Pedersen
@ 2019-09-05 20:14     ` Bert Wesarg
  0 siblings, 0 replies; 9+ messages in thread
From: Bert Wesarg @ 2019-09-05 20:14 UTC (permalink / raw)
  To: Birger Skogeng Pedersen; +Cc: Git Mailing List, Pratyush Yadav

On Wed, Sep 4, 2019 at 8:00 PM Birger Skogeng Pedersen
<birger.sp@gmail.com> wrote:
>
> Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> a hotkey.
>
> With this patch, the user may toggle between the two options with
> CTRL/CMD+e.
>
> Signed-off-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> ---
>  git-gui.sh | 40 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 35 insertions(+), 5 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 5bc21b8..47c5db0 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -1445,7 +1445,7 @@ proc force_amend {} {
>         set commit_type $newType
>
>         set selected_commit_type amend
> -       do_select_commit_type
> +       ui_select_commit_type
>  }
>
>  proc rescan {after {honor_trustmtime 1}} {
> @@ -2640,6 +2640,16 @@ proc show_less_context {} {
>         }
>  }
>
> +proc toggle_commit_type {} {
> +       global selected_commit_type
> +       if {[string match amend* $selected_commit_type]} {

only $commit_type has multiple incarnations of amend, thus this should
have been $commit_type here.

Though I posted new patches which convert it first to b a checkbutton
and than addedyour keybinding patch on top of it.

Bert

> +               set selected_commit_type new
> +       } else {
> +               set selected_commit_type amend
> +       }
> +       ui_select_commit_type
> +}
> +
>  ######################################################################
>  ##
>  ## ui construction
> @@ -2824,13 +2834,31 @@ proc commit_btn_caption {} {
>         }
>  }
>
> +proc ui_select_commit_type {} {
> +       global selected_commit_type
> +       global ui_commit_type_commit ui_commit_type_amend
> +
> +       do_select_commit_type
> +       if {$selected_commit_type eq {new}} {
> +               .mbar.commit entryconf [mc "New Commit"] \
> +                       -accelerator {}
> +               .mbar.commit entryconf [mc "Amend Last Commit"] \
> +                       -accelerator $::M1T-E
> +       } elseif {$selected_commit_type eq {amend}} {
> +               .mbar.commit entryconf [mc "New Commit"] \
> +                       -accelerator $::M1T-E
> +               .mbar.commit entryconf [mc "Amend Last Commit"] \
> +                       -accelerator {}
> +       }
> +}
> +
>  if {[is_enabled multicommit] || [is_enabled singlecommit]} {
>         menu .mbar.commit
>
>         if {![is_enabled nocommit]} {
>                 .mbar.commit add radiobutton \
>                         -label [mc "New Commit"] \
> -                       -command do_select_commit_type \
> +                       -command ui_select_commit_type \
>                         -variable selected_commit_type \
>                         -value new
>                 lappend disable_on_lock \
> @@ -2838,7 +2866,8 @@ if {[is_enabled multicommit] || [is_enabled singlecommit]} {
>
>                 .mbar.commit add radiobutton \
>                         -label [mc "Amend Last Commit"] \
> -                       -command do_select_commit_type \
> +                       -accelerator $M1T-E \
> +                       -command ui_select_commit_type \
>                         -variable selected_commit_type \
>                         -value amend
>                 lappend disable_on_lock \
> @@ -3315,14 +3344,14 @@ set ui_coml .vpane.lower.commarea.buffer.header.l
>  if {![is_enabled nocommit]} {
>         ${NS}::radiobutton .vpane.lower.commarea.buffer.header.new \
>                 -text [mc "New Commit"] \
> -               -command do_select_commit_type \
> +               -command ui_select_commit_type \
>                 -variable selected_commit_type \
>                 -value new
>         lappend disable_on_lock \
>                 [list .vpane.lower.commarea.buffer.header.new conf -state]
>         ${NS}::radiobutton .vpane.lower.commarea.buffer.header.amend \
>                 -text [mc "Amend Last Commit"] \
> -               -command do_select_commit_type \
> +               -command ui_select_commit_type \
>                 -variable selected_commit_type \
>                 -value amend
>         lappend disable_on_lock \
> @@ -3843,6 +3872,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
>  bind .   <$M1B-Key-plus> {show_more_context;break}
>  bind .   <$M1B-Key-KP_Add> {show_more_context;break}
>  bind .   <$M1B-Key-Return> do_commit
> +bind .   <$M1B-Key-e> toggle_commit_type
>  foreach i [list $ui_index $ui_workdir] {
>         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
>         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }
> --
> 2.21.0.windows.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-09-05 20:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04  5:58 [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-04 17:36 ` Pratyush Yadav
2019-09-04 17:59   ` [PATCH v2] git-gui: add " Birger Skogeng Pedersen
2019-09-05 20:14     ` Bert Wesarg
2019-09-04 18:55   ` [PATCH] Add " Bert Wesarg
  -- strict thread matches above, loose matches on Subject: below --
2019-09-02 19:49 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
2019-09-02 19:56 ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-03  8:52   ` Bert Wesarg
2019-09-03 10:25     ` Bert Wesarg
2019-09-03 16:20     ` Bert Wesarg

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).