From: Norman Rasmussen <norman@rasmussen.co.za>
To: Jeff King <peff@peff.net>
Cc: Norman Rasmussen via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] diff-highlight: fix a whitespace nit
Date: Mon, 14 Oct 2019 21:34:55 -0700 [thread overview]
Message-ID: <CAGF1phZk9_9Se++beXxDxQZ+Y6ucrFnBWJTVJfATMYyk4=Yn=Q@mail.gmail.com> (raw)
In-Reply-To: <20191015042006.GC32308@sigill.intra.peff.net>
On Mon, Oct 14, 2019 at 9:20 PM Jeff King <peff@peff.net> wrote:
> There are a few lines just above that have 8+ spaces. Arguably those
> could be tabs, too, depending on your view of tabs. We usually do "8
> spaces is a tab" in the Git project, but the oft-repeated "tabs to
> indent, spaces to align" mantra would apply here (and I suspect you're
> using a different tabwidth since you noticed this one case). So I'd just
> as soon leave them be, and take your patch as-is.
Yep, the lines above are using the spaces to align the sections of the
multi-line if statement. This happens again for the return statements
in highlight_pair and is_pair_interesting. So this is the only line
that doesn't stick to the rule (and probably because of editor
auto-indenting). I have another change for the same change (which I'll
send once I've written tests) and I only noticed this line when I
changed my editor's default tabwidth after a while of coding.
--
- Norman Rasmussen
- Email: norman@rasmussen.co.za
- Home page: http://norman.rasmussen.co.za/
prev parent reply other threads:[~2019-10-15 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 3:31 [PATCH 0/1] diff-highlight: fix a whitespace nit Norman Rasmussen via GitGitGadget
2019-10-15 3:31 ` [PATCH 1/1] " Norman Rasmussen via GitGitGadget
2019-10-15 4:20 ` Jeff King
2019-10-15 4:34 ` Norman Rasmussen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGF1phZk9_9Se++beXxDxQZ+Y6ucrFnBWJTVJfATMYyk4=Yn=Q@mail.gmail.com' \
--to=norman@rasmussen.co.za \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).