From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-11.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 6F4121F8C1 for ; Mon, 4 May 2020 18:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732336AbgEDSKd (ORCPT ); Mon, 4 May 2020 14:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1732076AbgEDSKc (ORCPT ); Mon, 4 May 2020 14:10:32 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B453C061A0E for ; Mon, 4 May 2020 11:10:32 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id d17so173134wrg.11 for ; Mon, 04 May 2020 11:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aKUNCFqjP63bKaygscQNIfFJ+kxHW6HnDOFGcdbc42o=; b=JaZSvUtRlRyuP/hsYPOFWLcFuz6bM2TqELiQQmOj+9OK/S9L7TPPn01vR5WuUsSM0x liNM3pR52UnmnqVNse7ET1kROdkGUKAavA7JfzSsaGiGDR89olhjqlf4eQdndS8y7W5m IkfqGfsNV30wp+ZhmrbyRMDCWPPNdoskHHtYqezaW3fA7sUOxA5Jn1sAsdbvrBAmAnHv f20caEkir0yrTakyFL/AI79SFqQs9e6VKrFLxdfwBSi2SV1UOJQp8pqwvYx+EJOi8W2d SflO8Jj19PgPZRkhIj+oxhYTP57u1EPzfOzzi1aglDBjPm9AkN26UsdpyTSH6L7fjIlN d1MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aKUNCFqjP63bKaygscQNIfFJ+kxHW6HnDOFGcdbc42o=; b=J9KUzg/hcxRLMlvosg6I4bnspuTdmyFNDS+KhCOIzFj9Bvmsoc7o2ovA3f09U/ZzOo JMxJGoi0LMVlgovI7Jd2Yhk3Hb920OgoQLyBwl09a2OJpUdSy7qRz5xscKds7DhdOVxy 9xxg1N0WAJx2bxRdVgKx7/I1AHi6O8uJwgt8ISMnrFBn0L4Vwj0WzPa5x5YVx7apU0ax 2xoVLmw6tXhi1UiAXmQvWHprK6TBBNSPN8JghnN8q4f5mNIzdna07uzwI94P++CIrNA8 Ika3VOYhurOKE2f3AlvChfoaMM39CxX2C7ioHfbVzjnxjG1sHpEPQE/xTPQaLSelUjml 0ajA== X-Gm-Message-State: AGi0PuaEdwLH46AoViO81it4eI9NagSOmorJNRjO2Sq+l5utTNbsyS0w 2br9tQt8ffWYNa+lXt9KcnJmi8Rq4o1I8POF4Zjbj1cp4OQ= X-Google-Smtp-Source: APiQypJmXs1zJdiIX9FAOGZjlIHmmkJH5cNQDFrCObKE5iW6HspqfxTtEWcCV8zo8mRkfBxLD8yLthyhN4TnqzscWcc= X-Received: by 2002:a5d:4f06:: with SMTP id c6mr655521wru.12.1588615830962; Mon, 04 May 2020 11:10:30 -0700 (PDT) MIME-Version: 1.0 References: <20200430212410.GF77802@google.com> In-Reply-To: <20200430212410.GF77802@google.com> From: Han-Wen Nienhuys Date: Mon, 4 May 2020 20:10:19 +0200 Message-ID: Subject: Re: [PATCH v10 03/12] create .git/refs in files-backend.c To: Emily Shaffer Cc: Han-Wen Nienhuys via GitGitGadget , git , Han-Wen Nienhuys Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Apr 30, 2020 at 11:24 PM Emily Shaffer wr= ote: > > On Mon, Apr 27, 2020 at 08:13:29PM +0000, Han-Wen Nienhuys via GitGitGadg= et wrote: > > > > > > This prepares for supporting the reftable format, which will want > > create its own file system layout in .git > > > > Signed-off-by: Han-Wen Nienhuys > > --- > > builtin/init-db.c | 2 -- > > refs/files-backend.c | 6 ++++++ > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/builtin/init-db.c b/builtin/init-db.c > > index 0b7222e7188..3b50b1aa0e5 100644 > > --- a/builtin/init-db.c > > +++ b/builtin/init-db.c > > @@ -251,8 +251,6 @@ static int create_default_files(const char *templat= e_path, > > * We need to create a "refs" dir in any case so that older > > * versions of git can tell that this is a repository. > > */ > > - safe_create_dir(git_path("refs"), 1); > > - adjust_shared_perm(git_path("refs")); > > Is the reftable completely replacing the refs/ dir? Or is the idea that > the refs/ dir is only used by the files backend? The commit message > makes it sound like it's an additional format to support, so I'm a > little confused. Why does the other currently-existing backend not need > the refs/ dir at this stage? I've dropped this patch from the series; it probably was from before the compat hack that is described in https://git.eclipse.org/r/#/c/157167/ for further clarification: reftable doesn't used the refs/ dir at all, but we still want to not confuse older git versions. --=20 Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado