From: Robert Coup <robert.coup@koordinates.com>
To: Bo Anderson <mail@boanderson.me>
Cc: Jeff King <peff@peff.net>, M Hickford <mirth.hickford@gmail.com>,
Bo Anderson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/4] osxkeychain: bring in line with other credential helpers
Date: Tue, 2 Apr 2024 15:54:31 +0100 [thread overview]
Message-ID: <CAFLLRp+Dd5M5Y+uoSpPk8-xpFHc_kBJJQfiHr4rt34ey0HAXbg@mail.gmail.com> (raw)
In-Reply-To: <98F1A6E9-4553-48BE-830C-8FDA9F3B5744@boanderson.me>
Hi Bo,
On Tue, 2 Apr 2024 at 14:53, Bo Anderson <mail@boanderson.me> wrote:
>
> The test script does not interact well with the env filtering. This was the case before this change too.
I guess without writing a helper-specific test or having some
per-helper-setup thing it's a bit tricky.
> To interact with your default keychain, you will need:
>
> GIT_TEST_CREDENTIAL_HELPER_SETUP="export HOME=$HOME”
>
> This is because the default macOS user keychain is local to your home directory - that’s why it’s giving errors about not finding any.
And with that, the tests all pass :-) Comparing with master where 7/21 failed.
Tested-by: Robert Coup <robert.coup@koordinates.com>
Could we document that setup step somewhere? I guess the simplest is
probably just to put it in the header of
t/t0303-credential-external.sh; maybe along the lines of the patch
below.
Rob :)
diff --git a/t/t0303-credential-external.sh b/t/t0303-credential-external.sh
index 095574bfc6..e4e693b233 100755
--- a/t/t0303-credential-external.sh
+++ b/t/t0303-credential-external.sh
@@ -27,6 +27,13 @@ timeout, you can test that feature with:
If your helper requires additional setup before the tests are started,
you can set GIT_TEST_CREDENTIAL_HELPER_SETUP to a sequence of shell
commands.
+
+- osxkeychain:
+
+ Because the default macOS user keychain is local to your home
+ directory, you will need:
+
+ GIT_TEST_CREDENTIAL_HELPER_SETUP="export HOME=$HOME”
'
. ./test-lib.sh
next prev parent reply other threads:[~2024-04-02 15:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 23:34 [PATCH 0/4] osxkeychain: bring in line with other credential helpers Bo Anderson via GitGitGadget
2024-02-17 23:34 ` [PATCH 1/4] osxkeychain: replace deprecated SecKeychain API Bo Anderson via GitGitGadget
2024-02-18 6:08 ` Eric Sunshine
2024-02-18 14:48 ` Bo Anderson
2024-02-18 18:39 ` Eric Sunshine
2024-02-17 23:34 ` [PATCH 2/4] osxkeychain: erase all matching credentials Bo Anderson via GitGitGadget
2024-02-17 23:34 ` [PATCH 3/4] osxkeychain: erase matching passwords only Bo Anderson via GitGitGadget
2024-02-17 23:34 ` [PATCH 4/4] osxkeychain: store new attributes Bo Anderson via GitGitGadget
2024-02-18 6:31 ` Eric Sunshine
2024-02-18 6:38 ` [PATCH 0/4] osxkeychain: bring in line with other credential helpers Eric Sunshine
2024-02-18 20:40 ` M Hickford
2024-02-18 23:23 ` Bo Anderson
2024-03-04 8:00 ` M Hickford
2024-03-07 9:47 ` Jeff King
2024-04-02 13:21 ` Robert Coup
2024-04-02 13:53 ` Bo Anderson
2024-04-02 14:54 ` Robert Coup [this message]
2024-04-01 21:40 ` M Hickford
2024-04-01 22:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLLRp+Dd5M5Y+uoSpPk8-xpFHc_kBJJQfiHr4rt34ey0HAXbg@mail.gmail.com \
--to=robert.coup@koordinates.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mail@boanderson.me \
--cc=mirth.hickford@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).