git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Juraj Oršulić" <juraj.orsulic@fer.hr>
To: Igor Djordjevic <igor.d.djordjevic@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [git-gui] Amending doesn't preserve timestamp
Date: Fri, 24 Mar 2017 11:23:16 +0100	[thread overview]
Message-ID: <CAEPqvow38g-X0nCLwMsMW4T+uu0ouDUQNmOGZp6BG0yjwR6pTQ@mail.gmail.com> (raw)
In-Reply-To: <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr>

Hi Igor! Thanks on for thoroughly searching the mailing list and on
your suggestions. I hope that someone will come up with a fix that
both preserves the author details and date correctly.

Regards,
Juraj


On Thu, Mar 23, 2017 at 11:54 PM, Igor Djordjevic
<igor.d.djordjevic@gmail.com> wrote:
> Hi Juraj,
>
> On 23/03/2017 15:26, Juraj Oršulić wrote:
>> Hello Igor (and others), I have something else to report about the
>> commit amend functionality in git-gui, and I think it could be
>> related to my original question. It seems that git-gui messes up
>> international signs on amending.
>>
>> E.g. I use git gui to make a commit, and all is OK:
>>
>> commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021
>> Author: Juraj Oršulić <juraj.orsulic@fer.hr>
>>
>> I open git gui again, click "Amend Last Commit", press "Commit", and I
>> get this in git log:
>>
>> commit 6e09ff9edcef863d92f02cf86e0307c27171aec0
>> Author: Juraj OrÅ¡uliÄ<U+0087> <juraj.orsulic@fer.hr>
>>
>>
>> Does anyone have any idea what could be the cause?
>>
>> I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on
>> http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72.
>
> Yes, I can confirm this.
>
> git version 2.12.1.windows.1
> git-gui version 0.21.GITGUI
> Tcl/Tk version 8.6.6
>
> That said, it seems there are quite some topics about it, like [1],
> [2], [3] and [4], but the most interesting one could be [5], having
> some kind of a "workaround" at the end as well.
>
> I`ve tried replacing the "commit.tcl" file as proposed, and it seems
> to work correctly -- just please do note that it actually reverts the
> file in question to an older version, maybe (re)introducing other
> bugs while fixing this specific one, so it could be something you may
> want to investigate into a bit more before actually using it for good.
>
> P.S. It might be a good idea to start a new topic in situations like
> this (send out a new e-mail instead of a reply), keeping unrelated
> discussions separated and helping interested parties spotting the new
> topic more easily.
>
> Regards,
> Buga
>
> [1] https://public-inbox.org/git/588ac268-0a1b-6787-e6a1-4164e7e9a784@b-i-t.de/T/#ea05ebbde162f9c230a2cc4f7099363aed68768f6
> [2] https://public-inbox.org/git/52E1627956F20E458D872C5961027EDC654FE17C@SGDS00759.zf-lenksysteme.net/T/#m0baea8c76e79f25bf92ca0deabe38efec2ee168d
> [3] https://public-inbox.org/git/50913C58.2000200@drmicha.warpmail.net/T/#m72664106ad3070235ea2628b61fc6203fbb5563e
> [4] https://public-inbox.org/git/20071212091744.GA5377@pvv.org/T/#m8490dd348389b4eea82eb1bdaab69227c946de19
> [5] https://github.com/git-for-windows/git/issues/761

      parent reply	other threads:[~2017-03-24 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-12 20:50 [git-gui] Amending doesn't preserve timestamp Juraj
2017-02-12 21:33 ` Igor Djordjevic BugA
     [not found] ` <8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr>
2017-02-12 21:40   ` Juraj
2017-02-12 23:06     ` Igor Djordjevic BugA
     [not found]     ` <70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr>
2017-03-23 14:26       ` Juraj Oršulić
2017-03-23 22:54         ` Igor Djordjevic
     [not found]         ` <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr>
2017-03-24 10:23           ` Juraj Oršulić [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEPqvow38g-X0nCLwMsMW4T+uu0ouDUQNmOGZp6BG0yjwR6pTQ@mail.gmail.com \
    --to=juraj.orsulic@fer.hr \
    --cc=git@vger.kernel.org \
    --cc=igor.d.djordjevic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).