From: Luke Diamand <luke@diamand.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Vinicius Kursancew <viniciusalexandre@gmail.com>,
Lars Schneider <larsxschneider@gmail.com>,
Git Users <git@vger.kernel.org>
Subject: Re: [PATCH] allow git-p4 to create shelved changelists
Date: Tue, 29 Nov 2016 12:47:04 +0000 [thread overview]
Message-ID: <CAE5ih78+br88ST3Hkiw744V62AZ9iYWZ4nD5EYjewfmQRWvsiw@mail.gmail.com> (raw)
In-Reply-To: <xmqqeg1vjug2.fsf@gitster.mtv.corp.google.com>
On 28 November 2016 at 19:06, Junio C Hamano <gitster@pobox.com> wrote:
> Vinicius Kursancew <viniciusalexandre@gmail.com> writes:
>
>> This patch adds a "--shelve" option to the submit subcommand, it will
>> save the changes to a perforce shelve instead of commiting them.
Looks good to me, thanks!
Works a treat.
Ack.
>>
>> Vinicius Kursancew (1):
>> git-p4: allow submit to create shelved changelists.
>>
>> Documentation/git-p4.txt | 5 +++++
>> git-p4.py | 36 ++++++++++++++++++++++--------------
>> t/t9807-git-p4-submit.sh | 31 +++++++++++++++++++++++++++++++
>> 3 files changed, 58 insertions(+), 14 deletions(-)
>
> Thanks, but I am a wrong person to review this change, so I'll
> summon two people who appear in "git shortlog --since=18.months"
> output to help review it.
>
>
next prev parent reply other threads:[~2016-11-29 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 9:33 [PATCH] allow git-p4 to create shelved changelists Vinicius Kursancew
2016-11-28 9:33 ` [PATCH] git-p4: allow submit " Vinicius Kursancew
2016-11-28 19:06 ` [PATCH] allow git-p4 " Junio C Hamano
2016-11-29 12:47 ` Luke Diamand [this message]
2016-11-29 18:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE5ih78+br88ST3Hkiw744V62AZ9iYWZ4nD5EYjewfmQRWvsiw@mail.gmail.com \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=viniciusalexandre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).