From: John Shahid <jvshahid@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>
Subject: Re: git push recurse.submodules behavior changed in 2.13
Date: Fri, 16 Jun 2017 10:11:46 -0400 [thread overview]
Message-ID: <CAE5=+KWOxNxsLGEV3FEf0i7WM20ttE_34D7qHiPAvRAWi+6JAg@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79ka=icZDS-6q2dGSxyeLxYw+Zd1M_DSWzmhmHYtbTQTvZw@mail.gmail.com>
On Mon, Jun 12, 2017 at 1:27 PM, Stefan Beller <sbeller@google.com> wrote:
> On Sat, Jun 10, 2017 at 6:28 AM, John Shahid <jvshahid@gmail.com> wrote:
>> bump. it's been a while and I'm still not clear what the next steps
>> are. I'm happy to send a patch but I would like to get a consensus
>> first.
>
> What do you want a consensus on?
> (Is the change in 2.13 a bug or feature? I considered it enough
> of a feature to not pursue an urgent bug fix. Maybe I misunderstood
> the discussion)
I was under the impression that Jonathan and may be others considered
the fact that `git push --recurse-submodules=on-demand` doesn't work
as before an unintentional change. He asked me previously if pushing
without a refspec will work for us and I responded with a yes. The
question remains if everyone is on board with change push without
refspec to use `push.default` in the parent repo as well as
submodules.
Cheers,
JS
prev parent reply other threads:[~2017-06-16 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 13:31 git push recurse.submodules behavior changed in 2.13 John Shahid
2017-05-29 2:44 ` Junio C Hamano
2017-05-29 4:20 ` Stefan Beller
2017-05-30 12:01 ` John Shahid
2017-05-30 17:05 ` Brandon Williams
2017-05-30 18:10 ` Jonathan Nieder
2017-05-31 14:50 ` John Shahid
2017-06-10 13:28 ` John Shahid
2017-06-12 17:27 ` Stefan Beller
2017-06-16 14:11 ` John Shahid [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE5=+KWOxNxsLGEV3FEf0i7WM20ttE_34D7qHiPAvRAWi+6JAg@mail.gmail.com' \
--to=jvshahid@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).