git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Flurin Feuerstein <flufeu@gmail.com>
To: git@vger.kernel.org
Subject: [Bug] git svn reports an error when a temp file is too large
Date: Wed, 21 Oct 2020 20:33:41 +0200	[thread overview]
Message-ID: <CADVShLvZ9Nwbix97g6OXGu6XwXxzbxNAa=VcpXqOzqTJoQp2+Q@mail.gmail.com> (raw)

git svn reports an error when a temp file is too large

The issue happens when (for an unknown reason) a temp file is
generated that is too large.
The exception is thrown in Git.pm on line 1344 in the function
File::Temp::tempfile().
The method breaks when a string with more than about 260 characters is inserted.
This is a limitation of the Perl File::Temp::tempfile() function
itself (tested on both linux and windows computers).

I have managed to work around the issue by changing the way the method
is invoked.
I have forked the git repository on github and made a quick fix there:
https://github.com/fxredeemer/git

Since I am completely inexperienced in Perl I am not sure whether this
fix represents clean code.

There is also another workaround in that repository for a follow up
issue (not part of this bug report).

Unfortunately I am unable to provide the repository since it is
company internal and not open source.

Used version: 2.28
Used OS: Win 10 2004 (also happening on Ubuntu 18.04)

Regards
Flurin

                 reply	other threads:[~2020-10-21 18:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADVShLvZ9Nwbix97g6OXGu6XwXxzbxNAa=VcpXqOzqTJoQp2+Q@mail.gmail.com' \
    --to=flufeu@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).