From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j6t@kdbg.org>, Trygve Aaberge <trygveaa@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] execv_dashed_external: wait for child on signal death
Date: Sat, 7 Jan 2017 16:07:43 +0700 [thread overview]
Message-ID: <CACsJy8BL+THd62J9e4QxuJ7HozUDe05959mTXBMK6E5i6a7WRQ@mail.gmail.com> (raw)
In-Reply-To: <20170107012223.c27toqr6ck44kfpj@sigill.intra.peff.net>
On Sat, Jan 7, 2017 at 8:22 AM, Jeff King <peff@peff.net> wrote:
> When you hit ^C to interrupt a git command going to a pager,
> this usually leaves the pager running. But when a dashed
> external is in use, the pager ends up in a funny state and
> quits (but only after eating one more character from the
> terminal!). This fixes it.
>
> Explaining the reason will require a little background.
>
> ...
I see I have exposed a bug and I'm glad you are around to fix it. Even
reading your explanation is scary enough, let alone finding it.
Thanks!
--
Duy
next prev parent reply other threads:[~2017-01-07 9:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 14:25 Regression: Ctrl-c from the pager in an alias exits it Trygve Aaberge
2017-01-06 6:40 ` Jeff King
2017-01-06 6:47 ` Jeff King
2017-01-06 7:26 ` Jeff King
2017-01-06 7:32 ` Jeff King
2017-01-06 13:19 ` Trygve Aaberge
2017-01-06 14:39 ` Johannes Sixt
2017-01-06 19:41 ` Jeff King
2017-01-06 22:42 ` Johannes Sixt
2017-01-06 23:20 ` Jeff King
2017-01-07 1:14 ` [PATCH 0/3] fix ^C killing pager when running alias Jeff King
2017-01-07 1:16 ` [PATCH 1/3] execv_dashed_external: use child_process struct Jeff King
2017-01-07 1:17 ` [PATCH 2/3] execv_dashed_external: stop exiting with negative code Jeff King
2017-01-07 1:22 ` [PATCH 3/3] execv_dashed_external: wait for child on signal death Jeff King
2017-01-07 7:28 ` Johannes Sixt
2017-01-07 7:34 ` Jeff King
2017-01-07 9:07 ` Duy Nguyen [this message]
2017-01-07 23:26 ` [PATCH 0/3] fix ^C killing pager when running alias Jacob Keller
2017-01-07 23:27 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8BL+THd62J9e4QxuJ7HozUDe05959mTXBMK6E5i6a7WRQ@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
--cc=trygveaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).