From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Kyle Meyer <kyle@kyleam.com>,
"Boettger, Heiko" <Heiko.Boettger@karlstorz.com>
Subject: Re: [PATCH/RFC] get_oid: new extended SHA-1 syntax to control resolution process
Date: Thu, 27 Jun 2019 09:52:45 +0700 [thread overview]
Message-ID: <CACsJy8AB+YVNi07G-nFkEhexyo2TG=qeNLT=JLksDVnDvs0gxg@mail.gmail.com> (raw)
In-Reply-To: <xmqqk1d8ch9g.fsf@gitster-ct.c.googlers.com>
On Thu, Jun 27, 2019 at 1:51 AM Junio C Hamano <gitster@pobox.com> wrote:
> > - <ref>@{literal} only accepts full ref. No turning "master" into
> > "refs/heads/master".
>
> This is already doable by saying "refs/heads/master", isn't it? Any
> ambiguous ones like a branch or a tag whose name is 'refs/heads/master'
> (i.e. refs/heads/refs/heads/master and refs/tags/refs/heads/master
> respectively) won't interfere once you use the explicit prefix refs/
> like so. I'd rather not to see this one added.
If refs/heads/master does _not_ exist, then ref/heads/master can
resolve to refs/heads/refs/heads/master, which I think is unexpected.
"ref not found" error or something should be returned instead.
--
Duy
next prev parent reply other threads:[~2019-06-27 2:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 14:32 specifying revision - how to enforce matching a tag/branch-name or revision only Boettger, Heiko
2019-06-20 22:54 ` Kyle Meyer
2019-06-21 15:16 ` Junio C Hamano
2019-06-25 11:43 ` Duy Nguyen
2019-06-25 14:35 ` AW: " Boettger, Heiko
2019-06-26 8:41 ` [PATCH/RFC] get_oid: new extended SHA-1 syntax to control resolution process Nguyễn Thái Ngọc Duy
2019-06-26 18:51 ` Junio C Hamano
2019-06-27 2:52 ` Duy Nguyen [this message]
2019-06-27 16:47 ` Junio C Hamano
2019-06-30 9:30 ` Jakub Narebski
2019-07-01 0:30 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8AB+YVNi07G-nFkEhexyo2TG=qeNLT=JLksDVnDvs0gxg@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=Heiko.Boettger@karlstorz.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).