From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] blame: output porcelain "previous" header for each file
Date: Mon, 27 Mar 2017 23:08:08 +0200 [thread overview]
Message-ID: <CACBZZX5AnG=hpnZCG3qFkLOO0gbgvt79ZYP3-oG5VjE8p284cQ@mail.gmail.com> (raw)
In-Reply-To: <20170106042051.nwjiuyyp7ljhs4sr@sigill.intra.peff.net>
On Fri, Jan 6, 2017 at 5:20 AM, Jeff King <peff@peff.net> wrote:
> +for output in porcelain line-porcelain
> +do
> + test_expect_success "generate --$output output" '
> + git blame --root -C --$output combined >output
> + '
> +
The --root option isn't needed here, the tests pass if it's removed.
Discovered while looking at the sorry state of our blame test suite
vis-a-vis tests for config, no tests for blame.showroot &
blame.blankboundary.
I'll submit that eventually, but meanwhile did you mean to omit --root
here, or is the test broken in some other way and it /should/ need
--root but doesn't?
next prev parent reply other threads:[~2017-03-27 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 4:15 [PATCH 0/3] fixing some random blame corner cases Jeff King
2017-01-06 4:17 ` [PATCH 1/3] blame: fix alignment with --abbrev=40 Jeff King
2017-01-06 4:18 ` [PATCH 2/3] blame: handle --no-abbrev Jeff King
2017-01-06 4:20 ` [PATCH 3/3] blame: output porcelain "previous" header for each file Jeff King
2017-01-09 21:57 ` Junio C Hamano
2017-03-27 21:08 ` Ævar Arnfjörð Bjarmason [this message]
2017-03-27 22:04 ` Jeff King
2017-01-08 3:39 ` [PATCH 0/3] fixing some random blame corner cases Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACBZZX5AnG=hpnZCG3qFkLOO0gbgvt79ZYP3-oG5VjE8p284cQ@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).