From: Jacob Keller <jacob.keller@gmail.com>
To: KES <kes-kes@yandex.ru>
Cc: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: Feature request: Improve diff algorithm
Date: Wed, 24 Jan 2018 10:06:53 -0800 [thread overview]
Message-ID: <CA+P7+xrVavoJkPmR17sbUS4zTH4ZioHJLgaKBvXg45UN1popxg@mail.gmail.com> (raw)
In-Reply-To: <12531516812201@web36o.yandex.ru>
On Wed, Jan 24, 2018 at 8:43 AM, KES <kes-kes@yandex.ru> wrote:
> Here is another place where diff can be improved:
> @@ -141,8 +140,9 @@ My_runops(pTHX)
> // Do not trace variables in DB:: module
> if( SvOK( inDB ) ) continue;
>
> - sv_inc_nomg( inDB );
>
> + // save_item( inDB );
> + sv_inc_nomg( inDB );
> dSP; SINFO; SAVETMPS;
>
> // printf( "SWITCH\n" );
>
>
> This would be better it the patch looks like:
> ( this patch is manually created just to light the idea. It may contain errors)
> @@ -140,6 +140,7 @@ My_runops(pTHX)
> // Do not trace variables in DB:: module
> if( SvOK( inDB ) ) continue;
>
> +
> + // save_item( inDB );
> sv_inc_nomg( inDB );
> -
> dSP; SINFO; SAVETMPS;
>
> As we can see, here the `sv_inc_nomg( inDB );` line is unchanged and `// save_item( inDB );` is added.
> Here we just add/remove empty lines and patch looks more better.
>
> I think (and this is my assumption), the the diff algorithm should take into account the string length.
> This is more better to add/remove more short lines
>
Hi,
Can you check if this is already handled by --indent-heuristic option
of diff? I think it might help this one already.
Thanks,
Jake
next prev parent reply other threads:[~2018-01-24 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 8:11 Feature request: Improve diff algorithm KES
2016-11-21 16:56 ` Jacob Keller
2016-11-21 18:17 ` Stefan Beller
2016-11-21 18:55 ` Jacob Keller
2018-01-24 16:43 ` KES
2018-01-24 18:06 ` Jacob Keller [this message]
2018-01-25 19:31 ` KES
2018-01-25 20:12 ` SZEDER Gábor
2018-01-25 20:49 ` SZEDER Gábor
2018-01-25 20:34 ` Junio C Hamano
2018-01-27 13:08 ` KES
2018-01-30 18:26 ` Stefan Beller
2018-01-26 18:29 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+P7+xrVavoJkPmR17sbUS4zTH4ZioHJLgaKBvXg45UN1popxg@mail.gmail.com \
--to=jacob.keller@gmail.com \
--cc=git@vger.kernel.org \
--cc=kes-kes@yandex.ru \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).