From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>, Paul Tan <pyokagan@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Small trivial annoyance with the nice new builtin "git am"
Date: Thu, 28 Jul 2016 16:35:58 -0700 [thread overview]
Message-ID: <CA+55aFxaia7_VkKKF3JiQt76+z5goz3vCpmWi-wTyBH=iaw5ew@mail.gmail.com> (raw)
Ok, it's no longer *that* new, but I only now noticed..
So I noticed that when I applied the last patch-bomb series from
Andrew, all the commit date-stamps are idential.
Now, it would be lovely if the new builtin git-am really was *so* fast
that it applies a 100+-patch series in under a second, but no, that's
not it. It's just that it only looks up the current time once.
That seems entirely accidental, I think that what happened is that
"ident_default_date()" just ends up initializing the default date
string once, and then the date is cached there, because it's now run
as a single process for the whole series.
I think I'd rather get the "real" commit dates, even if they show that
git only does a handful of commits a second rather than hundreds of
commits..
Something that just clears git_default_date in between "git am"
iterations, perhaps?
Linus
next reply other threads:[~2016-07-28 23:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 23:35 Linus Torvalds [this message]
2016-07-28 23:47 ` Small trivial annoyance with the nice new builtin "git am" Junio C Hamano
2016-07-29 0:29 ` Jeff King
2016-07-29 0:37 ` Linus Torvalds
2016-07-29 15:50 ` Jeff King
2016-07-29 17:15 ` Junio C Hamano
2016-07-29 18:05 ` [PATCH] reset cached ident date before creating objects Jeff King
2016-07-29 18:12 ` Linus Torvalds
2016-07-29 18:15 ` Junio C Hamano
2016-07-29 18:25 ` Jeff King
2016-07-30 2:11 ` Paul Tan
2016-07-30 2:41 ` Jeff King
2016-08-01 17:49 ` Junio C Hamano
2016-08-01 17:58 ` Junio C Hamano
2016-08-01 18:12 ` Jeff King
2016-08-01 18:17 ` Jeff King
2016-08-01 18:00 ` Jeff King
2016-08-01 19:37 ` Jeff King
2016-08-01 21:54 ` Junio C Hamano
2016-08-01 22:00 ` Jeff King
2016-07-29 18:10 ` Small trivial annoyance with the nice new builtin "git am" Junio C Hamano
2016-07-29 17:06 ` Junio C Hamano
2016-07-29 0:21 ` Jeff King
2016-07-29 0:32 ` Linus Torvalds
2016-07-29 8:19 ` Christian Couder
2016-07-29 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxaia7_VkKKF3JiQt76+z5goz3vCpmWi-wTyBH=iaw5ew@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).