git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Filippo Valsorda <valsorda@google.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: BUG: commit-reach.c:66: bad generation skip
Date: Wed, 10 Feb 2021 13:18:11 +0100	[thread overview]
Message-ID: <CA+2K_KqEzH7XmrHXd0Vniu+tBQpFwFnYPyzoj-kMhyN2NnoZFQ@mail.gmail.com> (raw)
In-Reply-To: <c19b6e23-96cd-fd0a-163d-826b46b51da0@gmail.com>

On Mon, Feb 8, 2021 at 3:26 AM Derrick Stolee <stolee@gmail.com> wrote:
> _This_ is interesting. I haven't heard of this problem happening
> in a released version of Git.
>
> I'm CC'ing Jonathan Nieder who recently saw this happening, but that
> was on a newer version than 2.30.0 with a topic that is not part
> of 2.30.0. But maybe the version shipped internally is versioned
> without extra information on top of the latest tag? (I see your
> @google.com email, which makes me think you have an internal version.)

Ah, the issue indeed first showed up as I was using the internal
version. I then installed mainline 2.30.0 to check that it reproduced
on the same local repository before reporting a bug.

> To better understand your situation, could you please run the
> following commands?
>
>         git config --get-regexp graph
>         git config features.experimental
>
> I'm specifically looking for values of fetch.writeCommitGraph and
> gc.writeCommitGraph.

fetch.writecommitgraph is enabled on the internal version.

$ git version
git version 2.30.0.478.g8a0d178c01-goog
$ git config --get-regexp graph
fetch.writecommitgraph true
$ git config features.experimental
$ ~/homebrew/bin/git version
git version 2.30.0
$ ~/homebrew/bin/git config --get-regexp graph
$ ~/homebrew/bin/git config features.experimental

I zipped up the repository and the worktree before running gc, so I can
run other commands for you if you need, but unfortunately I can't share
the archive, as it fetched from a private branch with security fixes.

  reply	other threads:[~2021-02-10 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07 22:28 BUG: commit-reach.c:66: bad generation skip Filippo Valsorda
2021-02-07 22:31 ` Filippo Valsorda
2021-02-08  2:26   ` Derrick Stolee
2021-02-10 12:18     ` Filippo Valsorda [this message]
2021-02-10 12:24       ` Derrick Stolee
2021-02-10 20:14         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+2K_KqEzH7XmrHXd0Vniu+tBQpFwFnYPyzoj-kMhyN2NnoZFQ@mail.gmail.com \
    --to=valsorda@google.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).