git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Users <git@vger.kernel.org>,
	peff@peff.net, tboegi@web.de, e@80x24.org, ttaylorr@github.com,
	peartben@gmail.com
Subject: Re: [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol
Date: Thu, 29 Jun 2017 20:46:21 +0200	[thread overview]
Message-ID: <C36BBCCA-6694-40EC-8E1A-36B0CB9D4B2D@gmail.com> (raw)
In-Reply-To: <xmqqinjetzgc.fsf@gitster.mtv.corp.google.com>


> On 29 Jun 2017, at 20:34, Junio C Hamano <gitster@pobox.com> wrote:
> 
> You seem to have squashed an unrelated "table-driven" clean-up into
> this step.  While I think the end result looks good, I would have
> liked to see it as a separate step, either as a preparatory "now we
> are going to add the third one, let's make it table-driven before
> doing so" step, or a follow-up "now we have done everything we
> wanted to do, let's make this clean-up at the end" step.

I am sorry. That was a misunderstanding - I thought you want to have 
this change squashed. 

The "preparatory" patch sounds good! 
Would you be OK if I send a v9 with this change?

Thanks,
Lars

  reply	other threads:[~2017-06-29 18:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 21:29 [PATCH v8 0/6] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-06-28 21:29 ` [PATCH v8 1/6] t0021: keep filter log files on comparison Lars Schneider
2017-06-28 21:29 ` [PATCH v8 2/6] t0021: make debug log file name configurable Lars Schneider
2017-06-28 21:29 ` [PATCH v8 3/6] t0021: write "OUT <size>" only on success Lars Schneider
2017-06-28 21:29 ` [PATCH v8 4/6] convert: put the flags field before the flag itself for consistent style Lars Schneider
2017-06-28 21:29 ` [PATCH v8 5/6] convert: move multiple file filter error handling to separate function Lars Schneider
2017-06-28 21:29 ` [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-06-29 18:34   ` Junio C Hamano
2017-06-29 18:46     ` Lars Schneider [this message]
2017-06-30 18:19       ` Junio C Hamano
2017-06-30 20:44         ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C36BBCCA-6694-40EC-8E1A-36B0CB9D4B2D@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peartben@gmail.com \
    --cc=peff@peff.net \
    --cc=tboegi@web.de \
    --cc=ttaylorr@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).