From: Kevin Willford <Kevin.Willford@microsoft.com>
To: Utsav Shah <utsav@dropbox.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Utsav Shah via GitGitGadget <gitgitgadget@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Utsav Shah <ukshah2@illinois.edu>
Subject: RE: [PATCH 1/1] unpack-trees: skip lstat based on fsmonitor
Date: Tue, 29 Oct 2019 20:12:00 +0000 [thread overview]
Message-ID: <BN6PR21MB078689FFE9ED95A31998F41A91610@BN6PR21MB0786.namprd21.prod.outlook.com> (raw)
In-Reply-To: <CAPYzU3NZZ-H_PWcRH_ooXzrYnRNjvF9ayX4_xeMJeMiHB=8fLg@mail.gmail.com>
> On Tuesday, October 29, 2019 1:07 PM Utsav Shah <utsav@dropbox.com>
> wrote:
>
> I'm getting the same test failures with or without
> GIT_TEST_FSMONITOR=t/t7519/fsmonitor-all and calling refresh_fsmonitor
> in tweak_fsmonitor. Could you share your patch? I'm probably messing
> something up, and I can try taking a look at fixing test cases as well.
I have the tests passing with the following commit.
https://github.com/kewillford/git/commit/3b1fdf5a4b1cd1d654b1733ce058faa4f087f75f
Things to note:
1. Not sure if fsmonitor was tested with split index so for now I removed that from the
check of entries in fsmonitor bitmap vs the number of cache entries
2. With these changes update-index was triggering the post-index-change hook with the
updated_skipworktree flag set which it wasn't before.
3. Copied the fsmonitor_last_update to the result index so the fsmonitor data will be
carried over to the new index in unpack_trees. This is to make sure that the next call
to git will have the fsmonitor data to use. We found that running `git status` after any
command that ran unpack_trees (checkout, reset --hard, etc.) was very slow the first
call but and subsequent calls were fast.
I'm still testing and reviewing these changes to make sure there isn't something I
have missed and that I made the right changes to the tests that were failing.
Kevin
next prev parent reply other threads:[~2019-10-29 20:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 15:23 [PATCH 0/1] unpack-trees: skip lstat on files based on fsmonitor Utsav Shah via GitGitGadget
2019-10-25 15:23 ` [PATCH 1/1] unpack-trees: skip lstat " Utsav Shah via GitGitGadget
2019-10-28 3:37 ` Junio C Hamano
2019-10-28 6:39 ` Utsav Shah
2019-10-28 19:23 ` Kevin Willford
2019-10-29 19:06 ` Utsav Shah
2019-10-29 20:12 ` Kevin Willford [this message]
2019-10-29 23:50 ` Utsav Shah
2019-10-30 0:21 ` Junio C Hamano
2019-10-30 16:41 ` Utsav Shah
2019-11-04 6:02 ` Junio C Hamano
2019-11-05 15:27 ` [PATCH v2 0/1] unpack-trees: skip stat on fsmonitor-valid files Utsav Shah via GitGitGadget
2019-11-05 15:27 ` [PATCH v2 1/1] " Utsav Shah via GitGitGadget
2019-11-05 21:40 ` Kevin Willford
2019-11-06 4:36 ` Utsav Shah
2019-11-06 17:24 ` Kevin Willford
2019-11-06 4:54 ` [PATCH v3 0/1] " Utsav Shah via GitGitGadget
2019-11-06 4:54 ` [PATCH v3 1/1] " Utsav Shah via GitGitGadget
2019-11-06 10:46 ` Junio C Hamano
2019-11-06 22:33 ` Utsav Shah
2019-11-08 3:51 ` Utsav Shah
2019-11-08 4:11 ` Junio C Hamano
2019-11-06 10:16 ` [PATCH v3 0/1] " Junio C Hamano
2019-11-20 8:32 ` [PATCH v4 " Utsav Shah via GitGitGadget
2019-11-20 8:32 ` [PATCH v4 1/1] " Utsav Shah via GitGitGadget
2019-11-21 4:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR21MB078689FFE9ED95A31998F41A91610@BN6PR21MB0786.namprd21.prod.outlook.com \
--to=kevin.willford@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=ukshah2@illinois.edu \
--cc=utsav@dropbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).